Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several component header render modifiers #8062

Merged

Conversation

michaelchadwick
Copy link
Contributor

Another attempt at removing those darned render-modifiers...

Removed render-modifiers for the header/titles of four components:

  • Program
  • Learner Group
  • Instructor Group
  • Curriculum Inventory Report

Still not sure if this is the way to go about it, but it does remove them and furthers the goal of ilios/ilios#5374

@michaelchadwick michaelchadwick changed the title Remove header render modifiers Remove several component header render modifiers Aug 9, 2024
@michaelchadwick michaelchadwick marked this pull request as ready for review August 12, 2024 14:51
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, and one discussion item. This is the way forward, I'm not sure if it's better either.

packages/frontend/.lint-todo Outdated Show resolved Hide resolved
@michaelchadwick michaelchadwick merged commit 05a7253 into ilios:master Aug 14, 2024
41 of 42 checks passed
@michaelchadwick michaelchadwick deleted the remove-header-render-modifiers branch September 13, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants