replaces SCSS main-list-box-header-title mixin with class equivalent #8999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
6667_main_list_box_header_title_mixin
branch
from
6e3ab27 to
492ce1b
Compare
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…in-list-box-header-title class. after refactoring main-list-box-header-title as class rule, the bottom margin styles coming from ilios-heading weren't properly overridden anymore. including ilios-heading inside the class style declaration corrects this.
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
dartajax
approved these changes
Dec 8, 2025
Member
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
seems fine to me - click tested areas mentioned and more - no visual diffs here or when using our new "percy"
Member
Author
|
@dartajax thanks for the review. i'd like to get either @jrjohnson or @michaelchadwick to have a look at this change in this PR before moving forward with this. the rest is standard fare. |
michaelchadwick
approved these changes
Dec 11, 2025
Contributor
michaelchadwick
left a comment
michaelchadwick
left a comment
There was a problem hiding this comment.
This all looks good. Moving that one pre-existing mixin to the new class works for now (it already had others). We can handle removing it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ilios/ilios#6667
refs ilios/ilios#6608