Skip to content

replaces SCSS main-list-box-header-title mixin with class equivalent #8999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dartajax merged 7 commits into from
Dec 11, 2025
Merged

replaces SCSS main-list-box-header-title mixin with class equivalent #8999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a539732
replaces main-list-box-header-title mixin with class equivalent.
stopfstedt Dec 8, 2025
9724c61
rm obsolete .courses-list style.
stopfstedt Dec 8, 2025
df23701
rm obsolete .reports-subjects style.
stopfstedt Dec 8, 2025
f07073f
rm obsolete style declaration.
stopfstedt Dec 8, 2025
492ce1b
replaces usage of SCSS mixin with class equivalent.
stopfstedt Dec 8, 2025
92c3fbd
corrects path to mixin imports.
stopfstedt Dec 8, 2025
9c3dc57
work around style conflicts by including ilios-heading directly in ma…
stopfstedt Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/frontend/app/components/courses/root.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export default class CoursesRootComponent extends Component {
</div>
<section class="courses">
<div class="header">
<h2 data-test-courses-header-title class="title">
<h2 data-test-courses-header-title class="main-list-box-header-title">
{{t "general.courses"}}
({{this.filteredCourses.length}})
</h2>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/curriculum-inventory/reports.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default class CurriculumInventoryReportsComponent extends Component {
</div>
<section class="reports">
<div class="header">
<h2 class="title">
<h2 class="main-list-box-header-title">
{{t "general.curriculumInventoryReports"}}
</h2>
{{#if (and this.canCreate this.selectedProgram)}}
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/curriculum-inventory/sequence-block-list.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default class SequenceBlockListComponent extends Component {
...attributes
>
<div class="header" data-test-header>
<div class="title" data-test-title>
<div class="main-list-box-header-title" data-test-title>
{{t "general.sequenceBlocks"}}
({{@sequenceBlocks.length}})
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/ilios-users.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default class IliosUsersComponent extends Component {
</div>
<section class="users">
<div class="header" data-test-header>
<span class="title" data-test-title>
<span class="main-list-box-header-title" data-test-title>
{{t "general.users"}}
</span>
<div class="actions">
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/instructor-groups/root.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export default class InstructorGroupsRootComponent extends Component {

<div class="main-list">
<div class="header">
<h2 class="title">
<h2 class="main-list-box-header-title">
{{t "general.instructorGroups"}}
{{#if this.isLoaded}}
({{this.filteredInstructorGroups.length}})
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/learner-groups/root.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export default class LearnerGroupsRootComponent extends Component {

<div class="main-list">
<div class="header">
<h2 class="title">
<h2 class="main-list-box-header-title">
{{t "general.learnerGroups"}}
{{#if this.isLoaded}}
({{this.filteredLearnerGroups.length}})
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/program-year/list.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default class ProgramYearListComponent extends Component {
<div class="program-year-list main-section" data-test-program-year-list ...attributes>
<section class="program-years" data-test-years>
<div class="header">
<div class="title">
<div class="main-list-box-header-title">
{{t "general.programYears"}}
</div>
{{#if @canCreate}}
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/programs/root.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export default class ProgramRootComponent extends Component {

<div class="main-list">
<div class="header">
<h2 class="title">
<h2 class="main-list-box-header-title">
{{t "general.programs"}}
</h2>
<div class="actions">
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/reports/subjects-list.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export default class ReportsSubjectsListComponent extends Component {
</div>
<section class="reports">
<div class="header">
<h2 data-test-courses-header-title class="title">
<h2 data-test-courses-header-title class="main-list-box-header-title">
{{t "general.reports"}}
({{this.filteredReports.length}})
</h2>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/school-list.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class SchoolListComponent extends Component {
<section class="school-list main-section" data-test-school-list ...attributes>
<section class="schools">
<div class="header">
<h2 class="title">
<h2 class="main-list-box-header-title">
{{t "general.schools"}}
</h2>
{{#if this.currentUser.isRoot}}
Expand Down
2 changes: 0 additions & 2 deletions packages/frontend/app/styles/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@
@forward "components/reports/switcher";
@forward "components/reports/subject";
@forward "components/reports/subject-header";
@forward "components/reports/subjects";
@forward "components/reports/subjects-list";

@forward "components/school/visualize-session-type-vocabularies-graph";
Expand All @@ -140,7 +139,6 @@
@forward "components/school/emails-editor";

@forward "components/courses/root";
@forward "components/courses/list";
@forward "components/courses/new";
@forward "components/courses/loading";

Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/assign-students/manager.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@

.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}
}

.form {
Expand Down
9 changes: 0 additions & 9 deletions packages/frontend/app/styles/components/courses/list.scss
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/courses/root.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
min-height: 2rem;
@include m.main-list-box-header-actions;
Expand Down
4 changes: 0 additions & 4 deletions packages/frontend/app/styles/components/curriculum-inventory/reports-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
4 changes: 0 additions & 4 deletions packages/frontend/app/styles/components/curriculum-inventory/sequence-block-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/ilios-users.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/instructor-groups/root.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/learner-groups/root.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/program-year/list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/programs/root.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/reports/subjects-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
29 changes: 0 additions & 29 deletions packages/frontend/app/styles/components/reports/subjects.scss
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions packages/frontend/app/styles/components/school-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
.header {
@include m.main-list-box-header;

h2 {
@include m.ilios-heading;
}

.title {
@include m.main-list-box-header-title;
}

.actions {
@include m.main-list-box-header-actions;
}
Expand Down
9 changes: 0 additions & 9 deletions packages/ilios-common/app/styles/ilios-common/mixins/main-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,6 @@
}
}

@mixin main-list-box-header-title {
@include ilios-heading.ilios-heading-h4;
@include font-size.text-align-bottom;
margin-bottom: 0.5rem;
@include media.for-laptop-and-up {
margin-bottom: 0;
}
}

@mixin main-list-box-header-actions {
@include media.for-laptop-and-up {
text-align: right;
Expand Down
1 change: 1 addition & 0 deletions packages/ilios-common/app/styles/ilios-common/shared.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@forward "shared/loading-shimmer";
@forward "shared/loading-text";
@forward "shared/main-section";
@forward "shared/main-list-box-header-title";
@forward "shared/normalize-external-editor";
@forward "shared/text-wrap";
@forward "shared/user-search";
Expand Down
13 changes: 13 additions & 0 deletions packages/ilios-common/app/styles/ilios-common/shared/main-list-box-header-title.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@use "../mixins/font-size";
@use "../mixins/ilios-heading";
@use "../mixins/media";

.main-list-box-header-title {
@include ilios-heading.ilios-heading;
@include ilios-heading.ilios-heading-h4;
@include font-size.text-align-bottom;
margin-bottom: 0.5rem;
@include media.for-laptop-and-up {
margin-bottom: 0;
}
}
Loading