Update c2rust-refactor to nightly-2022-08-08 #1328
Conversation
| let (defaultness, generics, sig, body) = expect!([i.kind] | ||
| ItemKind::Fn(box Fn { defaultness, generics, sig, body }) | ||
| => (defaultness, generics, sig, body)); |
There was a problem hiding this comment.
Internal macro from src/macros.rs that tries to match a value against the given pattern, and panics if the matching fails. We could try to get rid of it but it's already used in a hundred other places, so I'm not sure it's worth the effort.
There was a problem hiding this comment.
Perhaps. It's not very clear what it does vs. assert_matches!, although I'm not sure if it's worth the effort. I'd definitely prefer to use assert_matches! and matches! over the handrolled matches! and expect! here.
There was a problem hiding this comment.
For new ones, though, I'd rather just use assert_matches!.
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
2 times, most recently
from
ac75014 to
c958fe0
Compare
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
from
c958fe0 to
b0a8be1
Compare
| if let Some(ldid) = def_id.as_local() { | ||
| let mod_hir_id = self.cx.ty_ctxt().parent_module_from_def_id(ldid); | ||
| let mod_id = self.cx.hir_map().local_def_id_to_node_id(mod_hir_id); |
There was a problem hiding this comment.
Do we want to put this idiom in its own function? It's used a lot.
There was a problem hiding this comment.
I guess that doesn't need to be done here in this PR.
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
3 times, most recently
from
da612cb to
073e366
Compare
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
from
4a917b1 to
b998b55
Compare
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
2 times, most recently
from
c351a8f to
71e9d3d
Compare
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
from
71e9d3d to
c42bdd0
Compare
Update the refactoring tool to build and run with the same Rust nightly as the transpiler.