ci: run testsuite python2 transpilation #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
3 times, most recently
from
80829c3 to
5f072a3
Compare
kkysen
reviewed
Oct 1, 2025
kkysen
added a commit
that referenced
this pull request
Oct 2, 2025
…ortable types The workaround for non-portable types for const macros is to insert a use-site cast to the portable type, but this works differently for fn ptrs, so while #1321 is fixed, just skip fn ptr const macros. This should get #1384 to pass CI by working around this issue there, and it should also workaround #1366, although #1366 in `libxml2` appears to have been fixed/worked around from some other change, as #1385 now passes CI.
Merged
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
from
5f072a3 to
07d748f
Compare
kkysen
reviewed
Oct 2, 2025
There was a problem hiding this comment.
@fw-immunant, it seems there are still some issues with assembly translation here.
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
from
4be1850 to
6a31786
Compare
kkysen
added a commit
that referenced
this pull request
Oct 2, 2025
…ortable types The workaround for non-portable types for const macros is to insert a use-site cast to the portable type, but this works differently for fn ptrs, so while #1321 is fixed, just skip fn ptr const macros. This should get #1384 to pass CI by working around this issue there, and it should also workaround #1366, although #1366 in `libxml2` appears to have been fixed/worked around from some other change, as #1385 now passes CI.
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
from
6a31786 to
620d453
Compare
kkysen
force-pushed
the
fw/python2-testsuite-ci
branch
from
620d453 to
369a05e
Compare
kkysen
changed the base branch from
master
to
kkysen/const-macros-skip-fn-ptrs
|
After disabling a test that tries to contact a nonexistent network host the testsuite now passes. I don't think the changes from the |
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
from
369a05e to
43b5c12
Compare
fw-immunant
changed the base branch from
kkysen/const-macros-skip-fn-ptrs
to
master
kkysen
approved these changes
Oct 6, 2025
users have run into issues with the testsuite's python2, so we should test it in CI more coverage is better, and it's not clear why this wasn't being included before
fw-immunant
force-pushed
the
fw/python2-testsuite-ci
branch
from
43b5c12 to
76b81e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users have run into issues with the testsuite's python2, so we should test it in CI
more coverage is better, and it's not clear why this wasn't being included before