Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new outer clothing options for secoffs, warden, and detective #1612

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

FutureExalt
Copy link

@FutureExalt FutureExalt commented Feb 8, 2025

ports some of the Disco Elysium coats from Frontier Station to impstation, with better credit for their original author from /tg/station.

both coats can be found inside the detective wardrobe vendor.

🆑

  • add: new roundstart coats for secoff, warden, and detective.

detective. arriving. on the scene
@hivehum
Copy link

hivehum commented Feb 8, 2025

these are slick but unfortunately i have to be consistent with #1492 and say that i don't like adding reference to other media with no substance to it

edit: also unless you actually altered the sprites you should not be crediting yourself in the meta.json

@FutureExalt
Copy link
Author

forgot the contribution guidelines for sprites lol. sorry

as for references and stuff, would edits to the sprite work for de-referencing? maybe new colors on them or some extra details; i mostly want to have something like this for detective for the purposes of adding more personalization and "types" of detective. right now we've got styles that are either sec-aligned, miami vice, or 30s noir detective

@hivehum
Copy link

hivehum commented Feb 8, 2025

my advice would be to learn more about the styles and design inspiration behind the outfit choices in disco elysium and draw a new sprite set inspired by but not directly based on them

@hivehum hivehum mentioned this pull request Feb 8, 2025
adds jackets from frontier station edited by sha-seng and hilda., secoffs and wardens get the field bomber while detectives get the field jacket.
@FutureExalt
Copy link
Author

FutureExalt commented Feb 9, 2025

equipped-OUTERCLOTHING-export

new sprites provided by @Sha-Seng, icon and hand sprites by me, json is the devil

the field bomber (top) is now a roundstart outer clothing choice for secoffs and wardens, and the field jacket (bottom) is a roundstart outer clothing choice for detectives.

@FutureExalt FutureExalt changed the title detective coats port from Frontier Station new outer clothing options for secoffs, warden, and detective Feb 9, 2025
@Sha-Seng
Copy link

Sha-Seng commented Feb 9, 2025

Though notably we're now getting other ideas, and for other departments...

Not my PR but maybe dooon't merge this yet.......... The other departments can be other PRs but i wanna make sure we got a back logo we like before we send it here

@hivehum
Copy link

hivehum commented Feb 10, 2025

this looks fine to me. @FutureExalt do you want me to draft this or should i merge it

@Sha-Seng
Copy link

We may need to mark it as a draft since Hilda and I are still working on the back logos to match the ones we're making for other departments

@FutureExalt
Copy link
Author

okay sorry i just got home. i'm gonna push one more commit later tonight to include the redone design on the back seeing as we're going whole hog on the other departments too, we'll just put the other bombers in separate PR

changed the description of the sec bomber and changed the design on the back of the sec bomber
@FutureExalt
Copy link
Author

okay we're all good on our end. 👍

@hivehum hivehum merged commit 685bdaf into impstation:master Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants