Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy admin & supply assistant roles #1640

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

mqole
Copy link

@mqole mqole commented Feb 10, 2025

these will need to be published alongside mapping changes.
supply assistant still uses the cargo tech marker for spawning, will change this when every map has it

currently the intern roles have no lockout timer. maybe this changes later when we've gone a few rounds with them

🆑

  • add: Supply and Command intern roles! If you've already played a lot of the department, don't worry. You won't need to reunlock anything!
  • tweak: QM now requires 6 hours of Salvage time, bumped up from 3.

@mqole mqole changed the title [WAIT TO MERGE] deploy admin & supply assistant roles deploy admin & supply assistant roles Feb 11, 2025
@mqole
Copy link
Author

mqole commented Feb 11, 2025

ITS READY TO GO!

@kipdotnet
Copy link

gimme a sec to cherrypick and test it

Comment on lines +16 to +18
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like 6 is a lot... maybe this role is secretly fun though. will probably need to be monitored

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah super open to reducing it, we'll see how we go

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it definitely feels high, especially for a role that only has 1 job slot and no upper playtime bounds. i can see this role being somewhat popular for rp value and theres likely gonna be newer players with great knowledge of their department who are locked out of playing head for a good while after losing contested rolls for admin assistant

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a single person slot? I would have thought itd have a decently high cap, the same way that the other trainee roles and service worker and stuff have

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh jeez it is limited to one, even on highpop maps. yeah id almost argue to nix the added requirement entirely and just keep this as a learner role for people to use at their own pace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait does supply assistant not have upper bounds either??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh jeez it is limited to one, even on highpop maps. yeah id almost argue to nix the added requirement entirely and just keep this as a learner role for people to use at their own pace

this is kinda my feeling on it too

all good points. might be good to put an upper playtime bound on it once it's had time to settle, same with supply assistant

i have no evidence other than gut feeling but i think people will treat this as a service worker-like role when they want to play a "command's lackey"-type character, which i think is valid.. putting an upper bound on playtime would cement it as a learner role but prevent this angle of roleplay. really depends on our design intent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I genuinely like it as an rp role. itll be nice to radio someone to grab me a coffee from the bar, thats cute and fun and I think a lot of people would rly enjoy it. genuinely I think we just axe the hard requirement added here for command time before heads and just leave this as "you can do this if you wanna"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can always encourage promotion into it ig? give it a few days and we'll see what direction it goes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I believe this role has lots of rp value and having it locked after a certain amount of time would be a bit sad to me

Copy link

@kipdotnet kipdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine

@kipdotnet kipdotnet merged commit 6b2db53 into impstation:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants