Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy admin & supply assistant roles #1640

Merged
merged 2 commits into from
Feb 11, 2025
Merged

deploy admin & supply assistant roles #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5fe88
uncommenting
mqole Feb 10, 2025
c7bfe17
Merge branch 'adminassist' of https://github.com/mqole/imp-station-14…
mqole Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
description: job-description-cargotech
playTimeTracker: JobCargoTechnician
# Begin DeltaV modifications - Add time requirement to cargo tech
# Uncomment once ready to deploy Supply Assistant
#requirements:
#- !type:DepartmentTimeRequirement
# department: Cargo
# time: 21600 # 6 hrs ~3 shifts.
requirements:
- !type:DepartmentTimeRequirement
department: Cargo
time: 21600 # 6 hrs ~3 shifts.
# End DeltaV modifications
startingGear: CargoTechGear
icon: "JobIconCargoTechnician"
Expand Down
5 changes: 4 additions & 1 deletion Resources/Prototypes/Roles/Jobs/Cargo/quartermaster.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@
time: 21600 #6 hrs
- !type:RoleTimeRequirement
role: JobSalvageSpecialist
time: 10800 #3 hrs (too popular)
time: 21600 #6 hrs
- !type:DepartmentTimeRequirement
department: Cargo
time: 72000 #20 hours, imp
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs
- !type:OverallPlaytimeRequirement
time: 144000 #40 hrs
weight: 10
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
- !type:DepartmentTimeRequirement
department: Engineering
time: 72000 #20 hrs, imp
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs
Comment on lines +16 to +18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like 6 is a lot... maybe this role is secretly fun though. will probably need to be monitored

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah super open to reducing it, we'll see how we go

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it definitely feels high, especially for a role that only has 1 job slot and no upper playtime bounds. i can see this role being somewhat popular for rp value and theres likely gonna be newer players with great knowledge of their department who are locked out of playing head for a good while after losing contested rolls for admin assistant

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a single person slot? I would have thought itd have a decently high cap, the same way that the other trainee roles and service worker and stuff have

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh jeez it is limited to one, even on highpop maps. yeah id almost argue to nix the added requirement entirely and just keep this as a learner role for people to use at their own pace

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait does supply assistant not have upper bounds either??

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh jeez it is limited to one, even on highpop maps. yeah id almost argue to nix the added requirement entirely and just keep this as a learner role for people to use at their own pace

this is kinda my feeling on it too

all good points. might be good to put an upper playtime bound on it once it's had time to settle, same with supply assistant

i have no evidence other than gut feeling but i think people will treat this as a service worker-like role when they want to play a "command's lackey"-type character, which i think is valid.. putting an upper bound on playtime would cement it as a learner role but prevent this angle of roleplay. really depends on our design intent

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I genuinely like it as an rp role. itll be nice to radio someone to grab me a coffee from the bar, thats cute and fun and I think a lot of people would rly enjoy it. genuinely I think we just axe the hard requirement added here for command time before heads and just leave this as "you can do this if you wanna"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can always encourage promotion into it ig? give it a few days and we'll see what direction it goes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I believe this role has lots of rp value and having it locked after a certain amount of time would be a bit sad to me

- !type:OverallPlaytimeRequirement
time: 144000 #40 hrs
weight: 10
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
- !type:DepartmentTimeRequirement
department: Medical
time: 72000 #20 hrs, imp
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs
- !type:OverallPlaytimeRequirement
time: 144000 #40 hrs
weight: 10
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Science/research_director.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- !type:DepartmentTimeRequirement
department: Science
time: 72000 #20 hrs, imp
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs
- !type:OverallPlaytimeRequirement
time: 144000 #40 hrs
weight: 10
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
- !type:DepartmentTimeRequirement
department: Security
time: 324000 # 90 hrs
- !type:DepartmentTimeRequirement
department: Command
time: 21600 #6 hrs
- !type:OverallPlaytimeRequirement
time: 144000 #40 hrs
weight: 10
Expand Down
4 changes: 2 additions & 2 deletions Resources/Prototypes/Roles/Jobs/departments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
- Courier # Imp
- Quartermaster
- SalvageSpecialist
#- SupplyAssistant # DeltaV - Uncomment once ready to deploy.
- SupplyAssistant # DeltaV

- type: department
id: Civilian
Expand Down Expand Up @@ -75,7 +75,7 @@
- ERTSecurity
- ERTEngineer
- DeathSquad
#- AdministrativeAssistant # Delta V - Uncomment once ready to deploy. Administrative Assistant, see Resources/Prototypes/_DV/Roles/Jobs/Command/administrative_assistant.yml
- AdministrativeAssistant # Delta V
primary: false
weight: 100

Expand Down
Loading