Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable otel logging, fail job when errors raised by otel #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bruno-DaSilva
Copy link

This MR adds two things:

  1. debug diagnostic logging when action is set to debug more, info logs otherwise (previously not logged at all)
  2. hook into the globalErrorHandler provided by the otel library to set the action as failed when there are any errors

This should make debugging configuration issues with the action (and help catching those issues in the first place).

@nikordaris
Copy link
Contributor

This feels like a mix of concerns. There is otel logging happening with GitHub core logging. Can we separate the concerns? I understand the original issues is GitHub not logging a failure, let's just focus on that?

@wolverian
Copy link

Resurrecting this a bit because I have a possibly stupid question. Shouldn't setting the environment variable OTEL_LOG_LEVEL=debug do the same thing as this, or am I confused? I can't even find the documentation for OTEL_LOG_LEVEL anymore, so maybe it's unspecified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants