-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from npm to pnpm #1875
Migrate from npm to pnpm #1875
Conversation
b79bbe4
to
abd39cf
Compare
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
d8ddb88
to
692a4ca
Compare
Merge punyflash/inertia with some tweaks and fixes
Merge punyflash/inertia with some tweaks and fixes
Merge punyflash/inertia with some tweaks and fixes
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
[inertiajs#1875] Migrate from npm to pnpm
It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it. I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881 I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library. Thanks to everyone who spent time looking at my PRs. |
Bummer dude 😕 We've been working really hard on Inertia.js v2.0 (as you can see in Taylor's Laracon keynote), so the project is far from dead — we're just in a bit of an awkward position between major versions. I apologize that your work has not received more attention, that's partly my fault for not having enough time to review PRs recently. I don't work on Inertia.js full time like other open source maintainers (ie. Laravel, Livewire), so for me it actually requires time out of my personal life. Because of that things just take longer, as much as I wish it didn't. Thanks for your contributions either way. |
Note: This is based from this branch #1874
This is just one small commit: 7dd0a03
Replace npm by pnpm.
Pnpm is a much better package manager. If you are curious about its differences, I recommend you to google it.
Syntax and usage is pretty much identical
The reason why it's a good idea is because pnpm properly scopes packages unlike npm. As you can see in the single commit of this branch, I had to add missing packages to few repos. This should have never worked in the first place. This prevent weird bugs as well where the wrong package version is used for building as well.
Also, using @inertiajs/core from the workspace would be a better approach because sometimes both adapter and core need an update. i.e adding a new type that would be missing from the core in the currently published version.
Pnpm automatically re-alias properly packages referenced from the workspace.
https://pnpm.io/workspaces