[Svelte] Improve typescript types + minor fixes #1881

jamesst20 · 2024-05-28T01:59:05Z

I have rebased all my commits in my repo (https://github.com/jamesst20/inertia) to include the latest changes and afterwards I have taken all my packages/svelte files there to overwrite the ones in the current repo. I have stripped down all unnecessary changes and all new features as well.

This PR only improve the types and fix some possible regression that I will comment in a few seconds in the diff

Edit: @reinink it's ready. i'm done adding comments :)

jamesst20 · 2024-05-28T01:59:42Z

packages/svelte/src/lib/components/App.svelte

@@ -2,17 +2,15 @@
  import Render, { h } from './Render.svelte'
  import store from '../store'

-  $$props


Does nothing

jamesst20 · 2024-05-28T02:01:50Z

packages/svelte/src/lib/components/Render.svelte

+  $: {
+    if (prevComponent !== component) {
+      key = Date.now()
+      prevComponent = component
    }
  }


Prior to the typescript merge we had

$: { if (prevComponent !== component) { key = Date.now() prevComponent = component } }

and with the typescript merge we are now having

function updateKey(component: InertiaComponentType) { if (prev !== component) { prev = component key = new Date().getTime() } } $: updateKey(component)

While it looks like to be the same, it ain't. Everything between ${...} is reactive and is able to trigger state update unlike when it's wrapped into a method. Maybe it doesn't matter, however I don't see any justification for that change

jamesst20 · 2024-05-28T02:04:17Z

packages/svelte/src/lib/components/SSR.svelte

  import type { Page } from '@inertiajs/core'
+  export type SSRProps = { id: string; initialPage: Page }


No changes here. Exporting the types to use in createInertiaApp for the SSR instead of casting to any for better typing.

jamesst20 · 2024-05-28T02:05:02Z

packages/svelte/src/lib/useForm.ts

@@ -184,8 +174,8 @@ export default function useForm<TForm extends Record<string, unknown>>(
            return options.onStart(visit)
          }
        },
-        onProgress: (event: AxiosProgressEvent) => {
-          this.setStore('progress', event)
+        onProgress: (event?: AxiosProgressEvent) => {


This is the real inertia@core signature

packages/svelte/src/lib/types.ts

joetannenbaum

Hi @jamesst20, thanks for this PR! @reinink asked me to give it a review, I have just a couple of items that need clarification whenever you have a moment.

packages/svelte/tsconfig.json

packages/svelte/src/lib/useForm.ts

packages/svelte/src/lib/createInertiaApp.ts

packages/svelte/src/lib/types.ts

jamesst20 · 2024-07-10T03:02:21Z

@joetannenbaum @reinink

What would be the next step?

jamesst20 · 2024-07-17T16:20:00Z

@joetannenbaum @reinink

What would be the next step?

Hey guys @joetannenbaum @reinink it's me again bothering you 😆 let me know if I can be of any help

joetannenbaum · 2024-07-17T16:24:28Z

Hey @jamesst20! Sorry for the delay here. This is on my list to review again tomorrow, I'll update you then.

joetannenbaum · 2024-07-18T16:23:48Z

This is looking good! Thanks @jamesst20. Just one final nit, let me know what you think.

kevin82222 · 2024-07-31T02:05:40Z

@joetannenbaum @reinink @jamesst20 Have anything to do more about this?
I looking forward to using inertia@svelte with TypeScript in my project~
Thanks everyone for this pr works!

jamesst20 · 2024-07-31T03:42:22Z

@joetannenbaum I applied the styling suggestion and rebased on the latest commit too

@joetannenbaum @reinink @jamesst20 Have anything to do more about this? I looking forward to using inertia@svelte with TypeScript in my project~ Thanks everyone for this pr works!

Not really, I have been running my own typescript fork for few months without troubles

jamesst20 · 2024-08-06T14:59:16Z

@reinink Could you please merge? :)

pedroborges

This is great work @jamesst20, thank you! Please see my comments.

After installing @types/lodash I got different type errors. I worked on a fix to those error and have opened a PR to your branch. Please review it when you get a chance.

packages/svelte/src/lib/components/Render.svelte

packages/svelte/src/lib/useForm.ts

Review useForm types

jamesst20 · 2024-08-10T01:30:13Z

@pedroborges All done! Nice addition to remove all the duplicated calls and checks for the data type being function or object :)

Ready to merge?

pedroborges · 2024-08-10T21:32:53Z

Ready to merge?

@jamesst20 please install @types/lodash. I didn't include that in my PR but only fixed the type errors, sorry for the confusion.

After that, I'd like to see if @joetannenbaum wants to review this once again. Then it will be good to merge.

Thanks again @jamesst20!

jamesst20 · 2024-08-11T04:44:43Z

Ready to merge?

@jamesst20 please install @types/lodash. I didn't include that in my PR but only fixed the type errors, sorry for the confusion.

After that, I'd like to see if @joetannenbaum wants to review this once again. Then we will be good to merge.

Thanks again @jamesst20!

Done!

@joetannenbaum @pedroborges @reinink Let me know if this can be merged

pedroborges

Thanks @jamesst20! Just tested locally and it looks good 👏

Let's just wait for @joetannenbaum and @reinink before we merge it 😉

jamesst20 · 2024-08-24T14:10:15Z

Thanks @jamesst20! Just tested locally and it looks good 👏

Let's just wait for @joetannenbaum and @reinink before we merge it 😉

Could we proceed? It doesn't look like anyone is looking into it?

joekrump · 2024-08-26T16:27:43Z

If others are required for review before this can be merged I suggest adding them as reviewers on the PR so they will be more likely to be aware that they are blocking if that is the case.

jamesst20 · 2024-08-31T19:01:20Z

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

[Svelte] Improve typescript types + minor fixes inertiajs#1881

kevin82222 · 2024-09-01T15:14:15Z

@jamesst20 It's really unfortunate to hear that the Inertia project might no longer be actively maintained. I understand why you decided to close your PRs, but it's still a pity, given all the valuable contributions you've made.
I'm particularly interested in the unofficial version of the library that you'll be maintaining, especially since I am using Svelte 5 in my projects. Could you please let me know how I can access your fork? It would be a huge help in keeping my projects running smoothly.
Thank you again for all your efforts and for continuing to support the community with your unofficial fork.

jamesst20 · 2024-09-01T15:43:57Z

@jamesst20 It's really unfortunate to hear that the Inertia project might no longer be actively maintained. I understand why you decided to close your PRs, but it's still a pity, given all the valuable contributions you've made. I'm particularly interested in the unofficial version of the library that you'll be maintaining, especially since I am using Svelte 5 in my projects. Could you please let me know how I can access your fork? It would be a huge help in keeping my projects running smoothly. Thank you again for all your efforts and for continuing to support the community with your unofficial fork.

With pleasure :) I'm glad I am not the only one interested into it :)

My fork is here https://github.com/jamesst20/inertia/

The main branch is for Svelte 5 and there is also a backup branch that has a Svelte 5 separate adapter. I would recommend you use the main branch since it will be the one I keep up to date but I only completed yesterday. The old branch have months of testing but it's mostly the same but forked from the current typescript implementation instead :)

Backup branch : https://www.npmjs.com/package/@jamesst20/inertia-svelte5

Main branch : https://www.npmjs.com/package/@jamesst20/inertia-svelte

Also use https://www.npmjs.com/package/@jamesst20/inertia-core

reinink · 2024-09-02T12:22:25Z

maintain

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

Bummer dude 😕

We've been working really hard on Inertia.js v2.0 (as you can see in Taylor's Laracon keynote), so the project is far from dead — we're just in a bit of an awkward position between major versions.

I apologize that your work has not received more attention, that's partly my fault for not having enough time to review PRs recently. I don't work on Inertia.js full time like other open source maintainers (ie. Laravel, Livewire), so for me it actually requires time out of my personal life. Because of that things just take longer, as much as I wish it didn't.

Thanks for your contributions either way.

pedroborges · 2024-09-02T13:07:40Z

@jamesst20, I totally get where you're coming from, and I'm really sorry for the frustration you've been feeling. We can definitely do better here. I haven't been as involved as I wished. I was away from the project for the last two years, but I'm back now and really grateful for everyone who's kept contributing in the meantime 🙇

The team has been heads down working on Inertia.js v2, especially leading up to the Laracon announcement last week. There are a lot of cool new features coming, and I'm excited to be more involved again!

Just last Friday I mentioned internally that getting #1881 and #1872 reviewed and approved was my top priority this week since I'm blocked by them too. I'd really appreciate it if you could reopen these two PRs. After that, I'll be focusing on fixing #1670 and adding all the new v2 stuff to the Svelte adapter so we can launch it with the other adapters next month.

Thanks again for all your hard work and contributions. It really means a lot!

kevin82222 · 2024-09-03T12:47:12Z

I appreciate the clarification, and I apologize for my earlier comment — it seems I misunderstood the situation. I had been following this PR because I need the functionality it provides, and I mistakenly thought the project might not be actively maintained.
It's great to hear that Inertia.js is actively being worked on and that v2.0 is in progress. I can imagine how challenging it must be to balance open-source work with personal life, so I completely understand the delays.
I'm excited to see the new features in the upcoming version, and I'll continue to follow the project closely. Thanks to the entire team for your hard work and dedication to this project!

pedroborges · 2024-09-12T21:59:49Z

#1963 has been merged and will be tagged in the next release 🥳

jamesst20 commented May 28, 2024

View reviewed changes

packages/svelte/src/lib/types.ts Outdated Show resolved Hide resolved

joetannenbaum reviewed Jun 26, 2024

View reviewed changes

jamesst20 force-pushed the ts-fixes branch from 2f51363 to ede5f25 Compare June 26, 2024 21:15

jamesst20 and others added 5 commits July 30, 2024 23:36

Improve typescript types + minor fixes

858f520

QA: Remove unused props type + add extra types just in case

aac53d4

QA: Remove plural

cafa16e

QA: Revert tsconfig change

e14cfb8

QA: Move the if server up

ea6cb40

jamesst20 force-pushed the ts-fixes branch from 12b689a to ea6cb40 Compare July 31, 2024 03:37

pedroborges requested changes Aug 10, 2024

View reviewed changes

packages/svelte/src/lib/components/Render.svelte Outdated Show resolved Hide resolved

packages/svelte/src/lib/useForm.ts Show resolved Hide resolved

pedroborges and others added 3 commits August 9, 2024 22:16

Review useForm types

19c0efc

QA: Update reactive if statement

eb00eea

Merge pull request #9 from inertiajs/pedro-ts-fixes

0c3809f

Review useForm types

jamesst20 requested a review from pedroborges August 10, 2024 16:18

QA: Add @types/lodash to fix svelte-check

5187a68

pedroborges approved these changes Aug 11, 2024

View reviewed changes

pedroborges mentioned this pull request Aug 13, 2024

Could not find a typescript declaration for @inertiajs/svelte and @inertiajs/svelte/server #1924

Closed

pedroborges requested a review from joetannenbaum August 28, 2024 20:29

jamesst20 closed this Aug 31, 2024

jamesst20 mentioned this pull request Aug 31, 2024

[Svelte] Improve typescript types + minor fixes #1881 jamesst20/inertia#10

Merged

jamesst20 added a commit to jamesst20/inertia that referenced this pull request Aug 31, 2024

Merge pull request #10 from jamesst20/ts-fixes

407bdc1

[Svelte] Improve typescript types + minor fixes inertiajs#1881

jamesst20 added a commit to jamesst20/inertia that referenced this pull request Aug 31, 2024

Merge pull request #10 from jamesst20/ts-fixes

d5882ca

[Svelte] Improve typescript types + minor fixes inertiajs#1881

jamesst20 deleted the ts-fixes branch August 31, 2024 19:38

jamesst20 added a commit to jamesst20/inertia that referenced this pull request Aug 31, 2024

[Svelte] Improve typescript types + minor fixes inertiajs#1881

f809834

jamesst20 added a commit to jamesst20/inertia that referenced this pull request Aug 31, 2024

[Svelte] Improve typescript types + minor fixes inertiajs#1881

20bcecd

jamesst20 added a commit to jamesst20/inertia that referenced this pull request Aug 31, 2024

[Svelte] Improve typescript types + minor fixes inertiajs#1881

f012095

pedroborges mentioned this pull request Sep 6, 2024

[Svelte] Improve typescript types + minor fixes #1963

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Svelte] Improve typescript types + minor fixes #1881

[Svelte] Improve typescript types + minor fixes #1881

jamesst20 commented May 28, 2024 •

edited

Loading

jamesst20 May 28, 2024

jamesst20 May 28, 2024 •

edited

Loading

jamesst20 May 28, 2024

jamesst20 May 28, 2024

joetannenbaum left a comment

jamesst20 commented Jul 10, 2024

jamesst20 commented Jul 17, 2024

joetannenbaum commented Jul 17, 2024

joetannenbaum commented Jul 18, 2024

kevin82222 commented Jul 31, 2024

jamesst20 commented Jul 31, 2024

jamesst20 commented Aug 6, 2024

pedroborges left a comment •

edited

Loading

jamesst20 commented Aug 10, 2024

pedroborges commented Aug 10, 2024 •

edited

Loading

jamesst20 commented Aug 11, 2024

pedroborges left a comment

jamesst20 commented Aug 24, 2024

joekrump commented Aug 26, 2024

jamesst20 commented Aug 31, 2024

kevin82222 commented Sep 1, 2024

jamesst20 commented Sep 1, 2024

reinink commented Sep 2, 2024

pedroborges commented Sep 2, 2024

kevin82222 commented Sep 3, 2024

pedroborges commented Sep 12, 2024

		import type { Page } from '@inertiajs/core'
		export type SSRProps = { id: string; initialPage: Page }

[Svelte] Improve typescript types + minor fixes #1881

[Svelte] Improve typescript types + minor fixes #1881

Conversation

jamesst20 commented May 28, 2024 • edited Loading

jamesst20 May 28, 2024

Choose a reason for hiding this comment

jamesst20 May 28, 2024 • edited Loading

Choose a reason for hiding this comment

jamesst20 May 28, 2024

Choose a reason for hiding this comment

jamesst20 May 28, 2024

Choose a reason for hiding this comment

joetannenbaum left a comment

Choose a reason for hiding this comment

jamesst20 commented Jul 10, 2024

jamesst20 commented Jul 17, 2024

joetannenbaum commented Jul 17, 2024

joetannenbaum commented Jul 18, 2024

kevin82222 commented Jul 31, 2024

jamesst20 commented Jul 31, 2024

jamesst20 commented Aug 6, 2024

pedroborges left a comment • edited Loading

Choose a reason for hiding this comment

jamesst20 commented Aug 10, 2024

pedroborges commented Aug 10, 2024 • edited Loading

jamesst20 commented Aug 11, 2024

pedroborges left a comment

Choose a reason for hiding this comment

jamesst20 commented Aug 24, 2024

joekrump commented Aug 26, 2024

jamesst20 commented Aug 31, 2024

kevin82222 commented Sep 1, 2024

jamesst20 commented Sep 1, 2024

reinink commented Sep 2, 2024

pedroborges commented Sep 2, 2024

kevin82222 commented Sep 3, 2024

pedroborges commented Sep 12, 2024

jamesst20 commented May 28, 2024 •

edited

Loading

jamesst20 May 28, 2024 •

edited

Loading

pedroborges left a comment •

edited

Loading

pedroborges commented Aug 10, 2024 •

edited

Loading