-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Svelte] Improve typescript types + minor fixes #1963
Conversation
Review useForm types
Hey @pedroborges If you ever reopen the minimal upgrade for Svelte 5, I found a bug this week where I noticed SSR is no longer working with newer build of Svelte 5 starting from next.179+. You may want to apply this as well This is because Svelte 5 uses anchors (comments) and the |
Thanks for letting me know @jamesst20, I'll check it out. Really appreciate your work on these PRs 🙇♂️ |
@joetannenbaum the adapter passes all props from server to every layout and page components. Since each component only declares the props it needs Svelte warns you about the extra ones. You only see these warnings in development so we are good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, thank you both for all of your work on it!
Reopening #1881 originally created by @jamesst20.