Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

test: ics20 send_transfer using mock chains #36

Merged
merged 51 commits into from
Dec 6, 2023

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Nov 7, 2023

Part of: #5

Description

Implements an ics20 test using mocks of a cosmos-based chain and a sovereign chain.

With this PR:

  • ✅ Mock Cosmos (send_transfer)  > ✅ Mock Rollup (recv_packet)
  • ✅ Mock Rollup (send_transfer) > ⚠️ Mock Cosmos (recv_packet): To make the recv_packet possible, we must refactor the TestApp abstraction first.

PR author checklist

  • Linked to GitHub issue.
  • Added tests.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

@rnbguy rnbguy requested a review from Farhad-Shabani November 7, 2023 20:27
@rnbguy rnbguy self-assigned this Nov 7, 2023
@rnbguy rnbguy force-pushed the rano/test/token-transfer branch from 297653e to 84f590f Compare November 8, 2023 17:19
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review December 6, 2023 06:03
@Farhad-Shabani Farhad-Shabani changed the title test: ics20 token transfer using mock chains test: ics20 send_transfer using mock chains Dec 6, 2023
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rnbguy for this awesome work.
I've been tinkering around to make the current abstracted mock Sovereign do its job – growing some blocks/headers and update the root states of the rollup - So can fetch the proofs of commitment, craft the MsgRecvPacket, shoot it over to the mock Cosmos chain and nail the token transfer tests in both directions.
But to make all this happen, I should give the mock Sovereign makeover. Wrapping up what we've done so far in this PR, and then diving into that refactoring.

@Farhad-Shabani Farhad-Shabani merged commit 45aaaf7 into main Dec 6, 2023
8 checks passed
@Farhad-Shabani Farhad-Shabani deleted the rano/test/token-transfer branch December 6, 2023 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants