Skip to content

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 18, 2025

Description

Adding in inclusion variant of filtering Catalyst Singed Documents for the v1/document/index endpoint

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy changed the title feat(cat-gateway): Modify v1/document/index endpoint id and ver request fields feat(cat-gateway): Modify v1/document/index endpoint id field Sep 18, 2025
Copy link
Contributor

github-actions bot commented Sep 18, 2025

Test Report | ${\color{lightgreen}Pass: 857/857}$ | ${\color{red}Fail: 0/857}$ |

/// Either a Single Document ID, or a Range of Document IDs
/// Either a Single Document ID, or a Range of Document IDs, or Inclusion from the List of
/// IDs
pub(crate) enum EqOrRangedId {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming of enum should be changed as it is no longer limited to just Eq and Range, just for ease of reading!

Copy link
Contributor

@nathanbogale nathanbogale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we've already addressed the support for ver and other than what @neil-iohk mentioned above,
LGTM

@damian-molinski
Copy link
Contributor

What will happen to actions and comments if i'll send request with template.id.in = F15_TEMPLATE_IDS?

I'm assuming only f15 comments will be returned since whey are referring to templates but actions are not. Will it mean no actions will be included?

@Mr-Leshiy
Copy link
Contributor Author

@damian-molinski yes, you are right. In such type of query no any proposal actions documents would be returned.

@Mr-Leshiy Mr-Leshiy added the do not merge yet PR is not ready to be merged yet label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

4 participants