-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-gateway): Modify v1/document/index
endpoint id
field
#3446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: f15/cat-gateway
Are you sure you want to change the base?
Conversation
v1/document/index
endpoint id
and ver
request fieldsv1/document/index
endpoint id
field
✅ Test Report | |
/// Either a Single Document ID, or a Range of Document IDs | ||
/// Either a Single Document ID, or a Range of Document IDs, or Inclusion from the List of | ||
/// IDs | ||
pub(crate) enum EqOrRangedId { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming of enum should be changed as it is no longer limited to just Eq and Range, just for ease of reading!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we've already addressed the support for ver and other than what @neil-iohk mentioned above,
LGTM
What will happen to I'm assuming only f15 comments will be returned since whey are referring to templates but actions are not. Will it mean no actions will be included? |
@damian-molinski yes, you are right. In such type of query no any proposal actions documents would be returned. |
Description
Adding
in
inclusion variant of filtering Catalyst Singed Documents for thev1/document/index
endpointPlease confirm the following checks