Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Full Level-Based Foraging(LBF) environment #218

Merged
merged 88 commits into from
Oct 30, 2024
Merged

Feat: Full Level-Based Foraging(LBF) environment #218

merged 88 commits into from
Oct 30, 2024

Conversation

WiemKhlifi
Copy link
Contributor

@WiemKhlifi WiemKhlifi commented Jan 18, 2024 •
edited
Loading

In this PR, we have introduced an implementation of the Level-Based Foraging (LBF) environment, incorporating actor-critic and random networks along with documentation.

Note: The gym version of the original implementation of LBF.

sash-a added 30 commits July 25, 2023 18:14
@sash-a
feat: types + generator poc done
d7b804a
@sash-a
feat: collision checking and resetting
181b314
@sash-a
feat: update types and implement more utils methods
5521591
@sash-a
fix: generator
6fc12f3
@sash-a
feat: more utils tests
4fcf676
@sash-a
feat: reward and test
631fc70
@sash-a
feat: observation spec and action mask
24e881a
@sash-a
fix: loading and eating and tests to go with it
b78e65d
@sash-a
feat: no foods are placed on edge or adj to other food
34be44a
@sash-a
feat: test that no foods are adjacent to eachother
37556df
@sash-a
chore: test slice around
013acd5
@sash-a
fix: state_to_obs
108f894
@sash-a
fix: obs - env no longer smokes - piping through
2f84d26
@sash-a
Merge branch 'main' into feat/lbf
e7cc966
@sash-a
feat: test state_to_obs
366772c
@sash-a
chore: clean and add in tests skeleton methods
26f7533
@sash-a
chore: pre-commit
236bf63
@sash-a
feat: place food on grid test
8ea7960
@sash-a
feat: test step and reset and done - fix small bugs
c6a0084
@sash-a
feat: tested eating multiple foods at once
042289e
@sash-a
feat: vector obs
af715bb
@sash-a
fix: local agent obs
f45d86e
@sash-a
feat: fix masking bug + add attribs to look more like rware
2052fbc
@sash-a
fix: fov was hardcoded
208b366
@sash-a
fix: correct reward
0eb27bf
@sash-a
feat: registered lbf
c9b78df
@sash-a
feat: implemented observers
ec78da2
@sash-a
feat: observer test and fix out of bounds bug in vector observer
03c584f
@sash-a
fix: tests and move obs spec to observers
812b71a
@sash-a
chore: pre-commit
48996eb
sash-a
sash-a requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Gone through most of the smaller files. Still need check generator, observer and env

README.md Show resolved Hide resolved
jumanji/environments/routing/lbf/tests_files/env_test.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/tests_files/env_test.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/utils.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/utils.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/generator.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/generator.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/generator.py Outdated Show resolved Hide resolved
docs/environments/lbf.md Outdated Show resolved Hide resolved
docs/environments/lbf.md Outdated Show resolved Hide resolved
sash-a
sash-a requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor extra comments after reviewing the rest, looks pretty much good to go after these few things

jumanji/environments/routing/lbf/observer.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/env.py Outdated Show resolved Hide resolved
docs/api/environments/lbf.md Show resolved Hide resolved
sash-a
sash-a requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things also can you please remove the test_files folder and put all tests in the env folder 🙏

jumanji/environments/routing/lbf/generator.py Outdated Show resolved Hide resolved
jumanji/environments/routing/lbf/viewer.py Outdated Show resolved Hide resolved
sash-a
sash-a previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @WiemKhlifi! 🔥

sash-a
sash-a approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@sash-a sash-a merged commit 85333d7 into instadeepai:main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sash-a sash-a sash-a approved these changes

@clement-bonnet clement-bonnet Awaiting requested review from clement-bonnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WiemKhlifi @CLAassistant @clement-bonnet @sash-a @SimonDuToit