Skip to content

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Sep 5, 2025

No description provided.

@dkhaldi dkhaldi changed the title [SYCL][E2E] limit the xfail to the failing cases in a SG32/joint_matr… [SYCL][E2E] limit the xfail to the failing cases in a SG32/joint_matrix_bfloat16.cpp Sep 5, 2025
@dkhaldi dkhaldi marked this pull request as ready for review September 8, 2025 13:57
@dkhaldi dkhaldi requested a review from a team as a code owner September 8, 2025 13:57
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this patch LGTM.
Just a side question: do we really need to keep

if (combinations[i].nsize == 8) { // architecture::intel_gpu_dg2*

in this test? Any plan to support SG=32 on DG2?

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Sep 8, 2025

if (combinations[i].nsize == 8) { // architecture::intel_gpu_dg2*

in this test? Any plan to support SG=32 on DG2?

Yes I also saw it was there at the same time as unsupported for DG2.
I think it is fine to keep it there to make the query comprehensive as this is really about the N value (in case we do support N=8 (not DG2 SG32)).

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Sep 8, 2025

@intel/llvm-gatekeepers, This should be ready to merge.
The failure (SYCL :: KernelCompiler/sycl_device_globals.cpp) in CI is already reported in #19965

@sarnex sarnex merged commit e62fb76 into intel:sycl Sep 8, 2025
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants