-
Notifications
You must be signed in to change notification settings - Fork 807
[SYCL] Fix for subbuffer #21022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[SYCL] Fix for subbuffer #21022
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
approved these changes
Jan 12, 2026
Contributor
cperkinsintel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
|
@intel/llvm-gatekeepers Can we merge it ? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
test-e2e/Basic/buffer/subbuffer.cpptest. It was failing Gen12 OpenCL. #15151Looks like we incorrectly create subbuffer with size which is smaller than anticipated.
Example
Expected result is
0 1 2 3 4 5 6 -7 -8 -9but without this change result is0 1 2 3 4 5 6 -7 8 9However when
MRequirement.MAccessRangeis replaced withMRequirement.MMemoryRangewe create subbuffer of size just 5 instead of 3 and expected result is valid.Here is tracker explaining why it happens on Gen12:
CMPLRLLVM-72513