Skip to content

[SYCL] Fix for subbuffer #21022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 5 commits into from
Jan 13, 2026
+3 −9
Merged

[SYCL] Fix for subbuffer #21022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48d71b3
test
dyniols Jan 8, 2026
78896ab
remove unsuported from subbuffer e2e
dyniols Jan 8, 2026
f61f8f1
update test
dyniols Jan 9, 2026
8262652
formatting fixed
dyniols Jan 9, 2026
dcbbc2a
fix
dyniols Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ ur_result_t AllocaSubBufCommand::enqueueImp() {
MMemAllocation, MemoryManager::allocateMemSubBuffer,
getContext(MQueue), MParentAlloca->getMemAllocation(),
MRequirement.MElemSize, MRequirement.MOffsetInBytes,
MRequirement.MAccessRange, std::move(EventImpls), UREvent);
MRequirement.MMemoryRange, std::move(EventImpls), UREvent);
Result != UR_RESULT_SUCCESS)
return Result;

Expand Down
10 changes: 2 additions & 8 deletions sycl/test-e2e/Basic/buffer/subbuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// UNSUPPORTED: (opencl && gpu)
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/15151

//
//==---------- subbuffer.cpp --- sub-buffer basic test ---------------------==//
//
Expand Down Expand Up @@ -126,8 +122,7 @@ void check1DSubBuffer(sycl::queue &q) {
}

// check buffer data in the area of the subbuffer
// OCL:GPU confused => 320 330 340 -350 -360 -370 -380 39 40 41
// every other device => 320 330 340 -350 -360 -370 -380 -390 -400 -410
// vec buffer result => 320 330 340 -350 -360 -370 -380 -390 -400 -410
for (int i = offset; i < offset + subbuf_size; ++i)
assert(vec[i] == (i < offset + offset_inside_subbuf ? i * 10 : i * -10) &&
"Invalid result in buffer overlapped by 1d sub buffer");
Expand All @@ -142,8 +137,7 @@ void check1DSubBuffer(sycl::queue &q) {
}

// check the copy of the subbuffer data after the first operation
// OCL:GPU => 32 33 34 -35 -36 -37 -38 0 0 0
// everyone else => 32 33 34 -35 -36 -37 -38 -39 -40 -41
// vec2 buffer result => 32 33 34 -35 -36 -37 -38 -39 -40 -41
for (int i = 0; i < subbuf_size; ++i)
assert(vec2[i] == (i < 3 ? (offset + i) : (offset + i) * -1) &&
"Invalid result in captured 1d sub buffer, vec2");
Expand Down