CVS-178131: perftest: iterate over the metadata entries first in filter_ep_devices

[jnagi-intel]

Fix for AUTO device type, to honor the ordering of the passed devices.

CVS-178131

[Copilot]

Pull request overview

This PR optimizes the device filtering logic in the perftest by reordering nested loops. The key change moves the iteration over metadata key-value pairs to the outer loop, with device iteration in the inner loop, which should improve performance when there are many devices but few filter criteria.

• Swapped loop order: metadata key-value pairs are now iterated in the outer loop instead of the inner loop

Comments suppressed due to low confidence (1)

onnxruntime/test/perftest/ort_test_session.cc:1

• The reordered loops now cause GetKeyValuePairs() to be called repeatedly for the same device when there are multiple filter criteria. This could be less efficient than the original code if GetKeyValuePairs() is expensive. Consider caching these values outside the outer loop or ensuring the original loop order is maintained if metadata retrieval has significant overhead.

// Copyright (c) Microsoft Corporation. All rights reserved.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[adrianlizarraga]

Changes look good. I would only recommend updating the usage documentation for this option to explicitly define what the expected matching order should be.

Perhaps a simple example like:
--filter_ep_devices "ov_device|NPU ov_device|CPU" means that an NPU device, if available, will be added first before one with cpu.

[jnagi-intel]

updated, also skipped if the device already added.

[MayureshV1]

Looks good to merge !