This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
Removed extra -1 y,z multiplier for static links #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I integrated the realsense static transforms with our system, I noticed there were a few unnecessary -1 multipliers in this driver for the camera extrinsic frames read from each realsense. When I overlaid them with the URDF, it became more obvious the -1's needed to go. The following are screenshots of the corrected static TF's read and published from a live realsense D415 camera (I also tested with a D435 and D435i and found these changes to work for all three models):
Front View:
Top View with Frame Names: