Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mappings: add edge_ngram prefix search #372

Merged
merged 13 commits into from
Aug 22, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Jul 24, 2024

❤️ Thank you for your contribution!

Close inveniosoftware/invenio-app-rdm#2759
Close inveniosoftware/invenio-app-rdm#2761

Description

Please describe briefly your pull request.

for the three vocabularies (funders, affiliations and awards) I created a test for searching for the prefix, which failed. I then added the edge_ngram search to the mapping which made the test pass

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack force-pushed the prefix-search branch 4 times, most recently from 8685270 to 3d676dc Compare July 29, 2024 13:12
Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of questions to clarify it.

I noticed that for affiliation we apply the tokenizer to title, name and acronym while on funders we only apply it for the name, is this intended?

@ntarocco ntarocco merged commit 24082ec into inveniosoftware:master Aug 22, 2024
4 checks passed
@carlinmack
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching with special characters result to 500 in affiliations Searching for prefixes of words fails
7 participants