Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put semver.org link between parenthesis #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avivace
Copy link
Member

@avivace avivace commented Jul 5, 2022

The help text for the version string is currently a bit strange to read:

Mostly relevant for software and dataset uploads. A semantic version string is preferred see [semver.org](https://semver.org/), but any version string is accepted.

This PR just puts the semver.org link between parenthesis so it's easier to follow the sense of the phrase.

@@ -28,7 +28,7 @@ export class VersionField extends Component {
{' '}
semver.org
</a>
, but any version string is accepted.
) but any version string is accepted.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
) but any version string is accepted.
) but any string is accepted.

Also, I suggest to remove "version string" to just use "string" here, because it better suggests that any string can be used as a version (while "version string" may suggest x.y.z). E.g. revision-conference-80 is accepted in this field, as well as

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

without triggering any validation error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant