Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put semver.org link between parenthesis #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Put semver.org link between parenthesis #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/components/VersionField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class VersionField extends Component {
<span>
<Trans>
Mostly relevant for software and dataset uploads. A semantic version
string is preferred see
string is preferred (see
<a
href="https://semver.org/"
target="_blank"
Expand All @@ -28,7 +28,7 @@ export class VersionField extends Component {
{' '}
semver.org
</a>
, but any version string is accepted.
) but any version string is accepted.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
) but any version string is accepted.
) but any string is accepted.

Also, I suggest to remove "version string" to just use "string" here, because it better suggests that any string can be used as a version (while "version string" may suggest x.y.z). E.g. revision-conference-80 is accepted in this field, as well as

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

without triggering any validation error

</Trans>
</span>
);
Expand Down