Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, ios): remove nanopb transitive dep from podspec #8021

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

Upstream firestore-ios-sdk-frameworks issue is fixed and the Firestore binary distribution now directly depends on nanopb as it should, so we should remove the workaround here.

This tangentially fixes compile of InAppMessaging which was specifying a mutually exclusive nanopb version range

Related issues

No related issue, noticed it while checking rnfbdemo repo for compile on Xcode 16

Release Summary

the commit is a single conventional commit and a rebase-merge should work, generating a successful release later

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

rnfbdemo compile tests this to make sure it works, it appears to work fine

https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Upstream firestore-ios-sdk-frameworks issue is fixed and the Firestore binary distribution now directly depends on nanopb as it should, so we should remove the workaround here.

This tangentially fixes compile of InAppMessaging which was specifying a mutually exclusive nanopb version range
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:14pm

@mikehardy
Copy link
Collaborator Author

The iOS error seems like a CI thing, not a "this works or not" thing, unsure what the known issues are in CI so I'm unsure

  coverage: true,
[🟥] listen EADDRINUSE: address already in use 0.0.0.0:8090

I re-ran the iOS test just in case it was a flake

@mikehardy mikehardy requested a review from dackers86 September 18, 2024 17:25
@Salakar Salakar changed the base branch from main to bump-ios-sdk September 19, 2024 13:13
@Salakar Salakar merged commit 6e0b94c into bump-ios-sdk Sep 19, 2024
19 of 20 checks passed
@Salakar Salakar deleted the remove-nanopb-firestore-dep branch September 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants