fix(ios, sdk): constrain transitive dependencies more tightly #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some were slipping out to 11.4.0 and causing compilation failures while the majority of the system was still on 11.3.0 we can't set exact versions because some pods don't version while others do (a previous issue) but we *can* set a max for compatibility reasons
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arifali123
approved these changes
Oct 22, 2024
elliottgorrell
added a commit
to elliottgorrell/sideproject-bootstrapper
that referenced
this pull request
Oct 22, 2024
Due to the issue invertase/react-native-firebase#8074 transitive deps weren't being pinned correctly resulting in an incompatible transitive dep breaking expo compile for iOS. The PR included in 21.1.1 fixes this
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some were slipping out to 11.4.0 and causing compilation failures while the majority of the system was still on 11.3.0
we can't set exact versions because some pods don't version while others do (a previous issue) but we can set a max for compatibility reasons
Related issues
Fixes:
asyncHeaderValue() async -> String?instead. #8073Release Summary
A single conventional commit
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Simply being able to build (and pass the build) in CI should be a proof there was no regression
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter