Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): deprecation warning for v8 API ahead of future major release #8132

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 14, 2024

Description

There is also a utils() method on FirebaseApp: https://rnfirebase.io/reference/app#utils

Not sure whether to leave it or to remove.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:46pm

@russellwheatley russellwheatley changed the base branch from main to v8-deprecations November 14, 2024 12:48
@mikehardy
Copy link
Collaborator

mikehardy commented Nov 14, 2024

I'm 100% certain people use the utils stuff, it is useful for at least 2 common scenarios:

  • do I have Play Services? (because if you are on Huawei or similar device you don't, and you need to either instruct the user about missing functionality or work very differently...)
  • am I running in the Test Lab? (because if you are in the test lab, you probably want to disable certain stuff like app-distribution updates, analytics, maybe other stuff...)

link to actually useful docs is https://rnfirebase.io/app/utils (the typedoc render of it is awful / useless)

It's typed pretty rough though from a typescript and typedoc perspect and there may be a better way to expose this functionality. It does need a home though IMHO

@russellwheatley
Copy link
Member Author

russellwheatley commented Nov 14, 2024

Yeah, I left it because I thought it was useful but I was caught in a bind between utility vs matching v9 API. So thought I'd pose the question.

FYI; Tests won't pass here until Crashlytics is merged as there's an e2e test that uses console.warn 👍

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants