Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-check, ios): remove import loop to fix protocol def warning #8133

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(app-check, ios): remove import loop to fix protocol def warning #8133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
*/

#import <Firebase/Firebase.h>
#import <FirebaseAppCheck/FIRAppCheck.h>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was just a style change from "" style imports to <>


#import <React/RCTUtils.h>

#import "RNFBApp/RNFBSharedUtils.h"
#import "RNFBAppCheckModule.h"

#import "FirebaseAppCheck/FIRAppCheck.h"

@implementation RNFBAppCheckModule
#pragma mark -
#pragma mark Module Setup
Expand Down
2 changes: 1 addition & 1 deletion packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
*/

#import <FirebaseAppCheck/FIRAppCheck.h>
#import "RNFBAppCheckProvider.h"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including FIRAppCheck here also contributed to the loop, so instead chain to the "parent" header file, and it includes all the others but this way they are included once-and-only-once


@interface RNFBAppCheckProviderFactory : NSObject <FIRAppCheckProviderFactory>

Expand Down
3 changes: 0 additions & 3 deletions packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
*/

#import "RNFBAppCheckProviderFactory.h"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one imports RNFBAppCheckProvider.h, which imports the others, including them again below caused the loop which caused the warning

#import <Firebase/Firebase.h>
#import <FirebaseAppCheck/FIRAppCheck.h>
#import "RNFBApp/RNFBSharedUtils.h"
#import "RNFBAppCheckProvider.h"

@implementation RNFBAppCheckProviderFactory

Expand Down
Loading