fix(app-check, ios): remove import loop to fix protocol def warning #8133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
import loops can apparently be the root cause of protocol definition issues, and if you ensure imports only happen once by chaining correctly then protocol definitions are found correctly and the warning goes away
mikehardy
force-pushed
the
@mikehardy/fix-appcheckproviderfactory-protocol-def-warning
branch
from
5a81ae4 to
e07cd2c
Compare
|
Yes! Finally nailed this compile warning - it's the last one that was left in the react-native-firebase apple native code after previous fixes |
mikehardy
commented
Nov 14, 2024
| @@ -16,10 +16,7 @@ | |||
| */ | |||
|
|
|||
| #import "RNFBAppCheckProviderFactory.h" | |||
There was a problem hiding this comment.
this one imports RNFBAppCheckProvider.h, which imports the others, including them again below caused the loop which caused the warning
mikehardy
commented
Nov 14, 2024
| @@ -15,7 +15,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| #import <FirebaseAppCheck/FIRAppCheck.h> | |||
| #import "RNFBAppCheckProvider.h" | |||
There was a problem hiding this comment.
including FIRAppCheck here also contributed to the loop, so instead chain to the "parent" header file, and it includes all the others but this way they are included once-and-only-once
mikehardy
commented
Nov 14, 2024
| @@ -16,13 +16,13 @@ | |||
| */ | |||
|
|
|||
| #import <Firebase/Firebase.h> | |||
| #import <FirebaseAppCheck/FIRAppCheck.h> | |||
There was a problem hiding this comment.
this was just a style change from "" style imports to <>
russellwheatley
approved these changes
Nov 14, 2024
mikehardy
deleted the
@mikehardy/fix-appcheckproviderfactory-protocol-def-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import loops can apparently be the root cause of protocol definition issues, and if you ensure imports only happen once by chaining correctly then protocol definitions are found correctly and the warning goes away
This warning:
Has been present since I originally implemented this feature to glue together the native SDK app check init process into something that looked like the firebase-js-sdk style, and I couldn't figure it out at the time
While reviewing another PR I saw this again though and it bothered me so I took another look at it. Stackoverflow provided the guidance that import loops can cause this unhelpful error and sure enough cleaning up the imports so they are singular in all cases appears to have fixed it
Related issues
Release Summary
conventional commit so merge+rebase will work
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
If app check still builds+works in CI at all this works, because this object is used in testing and it will work completely or break completely with this change
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter