Revert "Bug 5066 - Plasmagun and BFG don't play the explosion when they hit players, patch by Ensiform" #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey hit players, patch by Ensiform" This reverts commit f011fe9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to discussions in #801
This reverts commit f011fe9.
tested this on stream, here's a slomo clip with the effect on:
https://www.twitch.tv/mrnuclearmonster/clip/SpinelessSmoothMonkeyPoooound-TWvVqCxRdZlvjwjr
here's a slomo clip where the effect is off (original vanilla quake 3 behavior, at the start of the clip):
https://www.twitch.tv/mrnuclearmonster/clip/MistyCrazyYamWOOP-S27PYNfgGw8rX1Xg
Please use this opportunity to convince me otherwise. I think the only reasonable argument I can think of is that displaying the effect is potentially a bugfix.