feat(dapp): Set display name test #929
Open
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ress-and-set-display
VmMad
reviewed
Nov 18, 2025
| await dialog.getByRole('button', { name: /use current address/i }).click(); | ||
| await expect(dialog.getByText('Set as Display name')).toBeVisible(); | ||
|
|
||
| // "Set as Display name" lives in a clickable panel (div), not a button |
Member
There was a problem hiding this comment.
i think this comment is not necessary
Suggested change
| // "Set as Display name" lives in a clickable panel (div), not a button |
| }); | ||
| test('Connect Address and Set Display', async ({ appPage: page, context, sharedState }) => { | ||
| const keypair = Ed25519Keypair.deriveKeypair(sharedState.wallet.mnemonic ?? ''); | ||
| const name = `e2etest-${Math.floor(Math.random() * 100)}.iota`; |
Member
There was a problem hiding this comment.
Suggested change
| const name = `e2etest-${Math.floor(Math.random() * 100)}.iota`; | |
| const name = generateRandomName('display'); |
| const nameCards = page.getByTestId('name-card'); | ||
| await expect(nameCards.first()).toBeVisible({ timeout: 10_000 }); | ||
|
|
||
| const nameCard = page.getByTestId('name-card').first(); |
Member
There was a problem hiding this comment.
Suggested change
| const nameCard = page.getByTestId('name-card').first(); | |
| const nameCard = page.getByTestId("name-card").filter({ hasText: normalizeName(name, "at") })``` |
…ress-and-set-display
VmMad
reviewed
Nov 19, 2025
| timeout: 30_000, | ||
| }); | ||
| await dialog.getByRole('button', { name: 'Finish' }).click(); | ||
|
|
Member
There was a problem hiding this comment.
wdyt about making a fetch call to check that the changes reflect on the network?
Member
There was a problem hiding this comment.
not a blocker though, just a thought
…ress-and-set-display
…ress-and-set-display
msarcev
approved these changes
Nov 21, 2025
…ress-and-set-display
VmMad
requested changes
Nov 24, 2025
Member
VmMad
left a comment
VmMad
left a comment
There was a problem hiding this comment.
let's check that the name was correctly set as display, check either the network or in the UI the pill
KeitoTadashi
changed the title
…ress-and-set-display
Contributor
|
This pull request has been deployed to Vercel.
|
panteleymonchuk
approved these changes
Dec 2, 2025
panteleymonchuk
requested changes
Dec 2, 2025
Contributor
panteleymonchuk
left a comment
panteleymonchuk
left a comment
There was a problem hiding this comment.
For me all steps from test passed except last one. Pill doesn't visible, even if add timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
fixes #883