-
Notifications
You must be signed in to change notification settings - Fork 1
feat(dapp): Set display name test #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KeitoTadashi
wants to merge
23
commits into
develop
Choose a base branch
from
tooling-dapp/management-tests-connect-address-and-set-display
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2b8c529
feat(dapp): connect address test
KeitoTadashi 94437a6
feat(dapp): connect address and set display test
KeitoTadashi a1b192e
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi 98411f8
feat(dapp): polish
KeitoTadashi 08bc33e
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi 3f71ca5
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi eded71b
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi 4570edd
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi 8651035
fixes
KeitoTadashi f87bbd7
add timeout
KeitoTadashi bce8e58
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
msarcev db44d12
conflicts
KeitoTadashi d043109
lint
KeitoTadashi 51dfcbb
add check displayed pill
KeitoTadashi bf1bf56
feat(dapp): polish dropdowns
KeitoTadashi 02d5885
feat(dapp): cleanup
KeitoTadashi 50796d1
fix comments
KeitoTadashi f679121
chore(dapp): Remove commented code
msarcev cb901ed
feat(dapp): add set avatar amplitude event (#979)
Juligs ce66d1f
restore create subname test
KeitoTadashi 3b33aeb
revert
KeitoTadashi 304fbe8
Merge branch 'develop' into tooling-dapp/management-tests-connect-add…
KeitoTadashi 76b0952
revert
KeitoTadashi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about making a fetch call to check that the changes reflect on the network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker though, just a thought