Configures mesh collision schemas in convert_mesh.py
#3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zehao-wang <[email protected]>
Signed-off-by: zehao-wang <[email protected]>
zehao-wang
changed the title
Mayankm96
changed the title
convert_mesh.py
Mayankm96
requested changes
Oct 10, 2025
Signed-off-by: zehao-wang <[email protected]>
|
Dear maintainer, this is my first PR—apologies for any missteps. I received notifications about Python dependency and build issues from github notifications, but I only modified two files without touching build tools or those packages. Please let me know if there's anything I need to fix on my end. |
ooctipus
approved these changes
Oct 14, 2025
ooctipus
changed the title
convert_mesh.pyconvert_mesh.py
kellyguo11
approved these changes
Oct 14, 2025
kellyguo11
pushed a commit
that referenced
this pull request
Oct 15, 2025
# Description The collision approximation configuration changed in main branch, but the code in tools/convert_mesh.py does not sync. Fixes #3557 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: zehao-wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The collision approximation configuration changed in main branch, but the code in tools/convert_mesh.py does not sync.
Fixes #3557
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there