Skip to content

Fixed unintentional removal of '=' from command #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/2.3.0
Choose a base branch
from
+5 −16
Open

Fixed unintentional removal of '=' from command #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48c8241
Fix command formation
ndahile-nvidia Oct 1, 2025
9742af0
Added name in Contributors list
ndahile-nvidia Oct 1, 2025
3ee1971
rename veriable
ndahile-nvidia Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Guidelines for modifications:
* Miguel Alonso Jr
* Mingyu Lee
* Muhong Guo
* Narendra Dahile
* Neel Anand Jawale
* Nicola Loi
* Norbert Cygiert
Expand Down
20 changes: 4 additions & 16 deletions isaaclab.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,14 +511,8 @@ if "%arg%"=="-i" (
call :extract_python_exe
echo [INFO] Using python from: !python_exe!
REM Loop through all arguments - mimic shift
set "allArgs="
for %%a in (%*) do (
REM Append each argument to the variable, skip the first one
if defined skip (
set "allArgs=!allArgs! %%a"
) else (
set "skip=1"
)
for /f "tokens=1,* delims= " %%a in ("%*") do (
set "allArgs=%%b"
)
call !python_exe! !allArgs!
goto :end
Expand All @@ -527,14 +521,8 @@ if "%arg%"=="-i" (
call :extract_python_exe
echo [INFO] Using python from: !python_exe!
REM Loop through all arguments - mimic shift
set "allArgs="
for %%a in (%*) do (
REM Append each argument to the variable, skip the first one
if defined skip (
set "allArgs=!allArgs! %%a"
) else (
set "skip=1"
)
for /f "tokens=1,* delims= " %%a in ("%*") do (
set "allArgs=%%b"
)
call !python_exe! !allArgs!
goto :end
Expand Down
Loading