Skip to content

Conversation

adenzler-nvidia
Copy link

@adenzler-nvidia adenzler-nvidia commented Oct 6, 2025

Description

I ran these tests locally and the reward thresholds can be tightened a bit. I would like to have them tighter because we will start running the training tests in the newton CI as a forward-compatibility check.

Added a flag to disable the duration checks in the training tests to account for different type of hardware.

Updated to latest Newton and matching MJWarp.

Type of change

  • Test fix

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • [~] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [~] I have added tests that prove my fix is effective or that my feature works
  • [~] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [] I have added my name to the CONTRIBUTORS.md or my name already exists there

Signed-off-by: Alain Denzler <[email protected]>
@adenzler-nvidia
Copy link
Author

@AntoineRichard are the CI failures expected here?

Anything else that needs to be done to get this merged?

@AntoineRichard AntoineRichard changed the title [dev/newton] Tighten reward thresholds for Humanoid/G1/H1 training tests. [dev/newton] Tighten reward thresholds for Humanoid/G1/H1 training tests and update to latest newton. Oct 13, 2025
@AntoineRichard AntoineRichard changed the title [dev/newton] Tighten reward thresholds for Humanoid/G1/H1 training tests and update to latest newton. [Newton] Tighten reward thresholds for Humanoid/G1/H1 training tests and update to latest newton. Oct 13, 2025
@AntoineRichard AntoineRichard changed the title [Newton] Tighten reward thresholds for Humanoid/G1/H1 training tests and update to latest newton. [Newton] Tighten reward thresholds in tests and update to latest newton. Oct 13, 2025
@AntoineRichard AntoineRichard self-requested a review October 13, 2025 13:39
Copy link
Collaborator

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRichard AntoineRichard merged commit 8429231 into isaac-sim:dev/newton Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants