Fix warnings when running AutoMate env #3660
Open
+12
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results Summary2 547 tests 2 085 ✅ 2h 27m 12s ⏱️ For more details on these failures and errors, see this check. Results for commit 5d1ee06. |
Mayankm96
reviewed
Oct 10, 2025
Comment on lines
+126
to
+127
| gamma = torch.tensor([gamma], dtype=torch.float, device="cuda") | ||
| bandwidth = torch.tensor([bandwidth], dtype=torch.float, device="cuda") |
There was a problem hiding this comment.
Why is this using "cuda" and not the dev itself? Not sure if this will work nicely on multi-gpu setup?
Mayankm96
reviewed
Oct 10, 2025
Comment on lines
+64
to
+66
| bash_command = "NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS=0 isaaclab.bat -p" | ||
| elif sys.platform.startswith("linux"): | ||
| bash_command = "./isaaclab.sh -p" | ||
| bash_command = "NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS=0 ./isaaclab.sh -p" |
There was a problem hiding this comment.
What does the NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS do here specifically? Could you add a comment in the code if it needed for something specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there