Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow for SystemVerilog syntax checking #46

Merged
merged 17 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions .github/workflows/check_verilog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
name: synth-sv

on:
workflow_dispatch:
push:
branches:
- master
pull_request:
branches:
- master

env:
CIRCT_VERSION: 1.72.0
CIRCT_ARCHIVE: "circt-full-shared-linux-x64.tar.gz"
DEPENDENCIES_DIR: "deps"
MLIR_TARGETS_PATH: "lib/cmake/mlir/MLIRTargets.cmake"
BUILD_DIR: "build"
UTOPIA_EXECUTABLE: "src/umain"

jobs:
synthesize-system-verilog:
strategy:
matrix:
ssmolov marked this conversation as resolved.
Show resolved Hide resolved
kernel: [addconst, matrixmul2, movingsum, muxmul, polynomial2, scalar3]
config: [STUB]
## A workaround to intiailize an empty config array.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intiailize -> initialize

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

exclude:
- config: STUB
include:
## addconst configs.
- kernel: addconst
config: add_int_2
## matrixmul configs.
- kernel: matrixmul2
config: add_int_2_mul_int3
## movingsum configs.
- kernel: movingsum
config: add_int_2
- kernel: movingsum
config: add_int_8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good practice to enumerate different configs for same kernel in such way? Can't we do something like:

- kernel: somekernel
  config: [config1, config2]

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tried it 1-2 commits before. Instead of what we want Github parses it as a JSON array of two elements.

## muxmul configs.
- kernel: muxmul
config: add_int_2_mul_int3
## polynomial2 configs.
- kernel: polynomial2
config: add_int_2_mul_int3
- kernel: polynomial2
config: add_int_8_mul_int15
## scalar3 configs.
- kernel: scalar3
config: add_int_2_mul_int3

runs-on: ubuntu-latest
env:
MODULE_OUTPUT_PATH: "output.sv"
LIBRARY_OUTPUT_PATH: "lib.sv"
steps:
- name: Check out repository code
uses: actions/checkout@v4

- name: Download APT dependencies
run: |
sudo apt update
sudo apt install build-essential clang cmake g++ gcc liblpsolve55-dev lld make ninja-build libctemplate-dev verilator

- name: Download and configure CIRCT & LLVM
env:
CIRCT_SOURCE: "https://github.com/llvm/circt/releases/download/firtool-${{env.CIRCT_VERSION}}/${{env.CIRCT_ARCHIVE}}"
CIRCT_DIR: "firtool-${{env.CIRCT_VERSION}}"
run: |
mkdir "${{env.DEPENDENCIES_DIR}}"
cd "${{env.DEPENDENCIES_DIR}}"
wget "${{env.CIRCT_SOURCE}}"
tar -xvf "${{env.CIRCT_ARCHIVE}}"
sed -i 's'/\
'foreach(_target "LLVMSupport" "LLVMCore" "LLVMMC" "LLVMTarget" "LLVMAsmParser" "LLVMBinaryFormat" '\
'"LLVMBitReader" "LLVMBitWriter" "LLVMFrontendOpenMP" "LLVMTransformUtils" "LLVMTargetParser" "LLVMIRReader" '\
'"LLVMipo" "LLVMLinker" "LLVMPasses" "LLVMMCParser" "LLVMLineEditor" "LLVMTableGen" "LLVMCoroutines" "LLVMExecutionEngine" '\
'"LLVMObject" "LLVMOrcJIT" "LLVMJITLink" "LLVMAnalysis" "LLVMAggressiveInstCombine" "LLVMInstCombine" "LLVMScalarOpts" '\
'"LLVMVectorize" "LLVMX86CodeGen" "LLVMX86Desc" "LLVMX86Info" "LLVMX86AsmParser" "LLVMX86Disassembler" "CIRCTAffineToLoopSchedule" '\
'"CIRCTArcToLLVM" "CIRCTCalyxToFSM" "CIRCTCalyxToHW" "CIRCTCalyxNative" "CIRCTCombToArith" "CIRCTCombToLLVM" "CIRCTCombToSMT" '\
'"CIRCTConvertToArcs" "CIRCTDCToHW" "CIRCTExportChiselInterface" "CIRCTExportVerilog" "CIRCTFIRRTLToHW" "CIRCTFSMToSV" '\
'"CIRCTHandshakeToDC" "CIRCTHandshakeToHW" "CIRCTHWArithToHW" "CIRCTHWToLLHD" "CIRCTHWToLLVM" "CIRCTHWToBTOR2" "CIRCTHWToSMT" '\
'"CIRCTHWToSV" "CIRCTHWToSystemC" "CIRCTLLHDToLLVM" "CIRCTLoopScheduleToCalyx" "CIRCTMooreToCore" "CIRCTPipelineToHW" "CIRCTSCFToCalyx" '\
'"CIRCTSeqToSV" "CIRCTSimToSV" "CIRCTCFToHandshake" "CIRCTVerifToSMT" "CIRCTVerifToSV" "CIRCTExportFIRRTL" "CIRCTComb" '\
'"CIRCTCombTransforms" "CIRCTDebug" "CIRCTESI" "CIRCTFIRRTL" "CIRCTImportFIRFile" "CIRCTMSFT" "CIRCTMSFTTransforms" "CIRCTHW" '\
'"CIRCTLLHD" "CIRCTMoore" "CIRCTOM" "CIRCTOMEvaluator" "CIRCTSeq" "CIRCTSeqTransforms" "CIRCTSV" "CIRCTSVTransforms" "CIRCTFSM" '\
'"CIRCTFSMTransforms" "CIRCTHandshake" "CIRCTHandshakeTransforms" "CIRCTHWArith" "CIRCTVerif" "CIRCTLTL" "CIRCTEmit" "CIRCTFirtool" )'\
/\
'foreach(_target "LLVMSupport" "LLVMCore" "LLVMMC" "LLVMTarget" "LLVMAsmParser" "LLVMBinaryFormat" "LLVMBitReader" "LLVMBitWriter" '\
'"LLVMFrontendOpenMP" "LLVMTransformUtils" "LLVMTargetParser" "LLVMIRReader" "LLVMipo" "LLVMLinker" "LLVMPasses" "LLVMMCParser" '\
'"LLVMLineEditor" "LLVMTableGen" "LLVMCoroutines" "LLVMExecutionEngine" "LLVMObject" "LLVMOrcJIT" "LLVMJITLink" "LLVMAnalysis" '\
'"LLVMAggressiveInstCombine" "LLVMInstCombine" "LLVMScalarOpts" "LLVMVectorize" "LLVMX86CodeGen" "LLVMX86Desc" "LLVMX86Info" '\
'"LLVMX86AsmParser" "LLVMX86Disassembler")/' "${{env.CIRCT_DIR}}/${{env.MLIR_TARGETS_PATH}}"
cd "${{github.workspace}}"

- name: Configure Utopia HLS build
env:
CIRCT_DIR: "firtool-${{env.CIRCT_VERSION}}"
run: |
cmake -S . -B "${{env.BUILD_DIR}}" -G Ninja -DCMAKE_CXX_COMPILER=clang++ \
-DCMAKE_PREFIX_PATH="${{github.workspace}}/${{env.DEPENDENCIES_DIR}}/${{env.CIRCT_DIR}}" \
-DSRC_FILES="${{github.workspace}}/examples/${{matrix.kernel}}/${{matrix.kernel}}.cpp"

- name: Build Utopia HLS
run: |
cmake --build "${{env.BUILD_DIR}}"

- name: Run SystemVerilog modules generation
run: |
"${{env.BUILD_DIR}}/${{env.UTOPIA_EXECUTABLE}}" hls --config \
"${{github.workspace}}/examples/${{matrix.kernel}}/${{matrix.config}}.json" \
-l --out-sv "${{env.MODULE_OUTPUT_PATH}}" --out-sv-lib "${{env.LIBRARY_OUTPUT_PATH}}"

- name: Run Verilator
run: |
verilator --lint-only -Wall -Wno-DECLFILENAME "${{env.MODULE_OUTPUT_PATH}}" "${{env.LIBRARY_OUTPUT_PATH}}"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ For example, given subdirectory `polynomial2`, the compilation and execution com
```bash
cmake -S . -B build -G Ninja -DCMAKE_PREFIX_PATH=~/firtool-1.72.0 -DSRC_FILES="~/utopia-hls/examples/polynomial2/polynomial2.cpp"
cmake --build build
build/src/umain hls --config examples/polynomial2/polynomial2.json -a --out-sv output
build/src/umain hls --config examples/polynomial2/add_int_2_mul_int3.json -a --out-sv output
```

## DFCxx Documentation
Expand Down
File renamed without changes.
5 changes: 5 additions & 0 deletions examples/idct/add_int_1_sub_int_1_mul_int_3.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"ADD_INT": 1,
"SUB_INT": 1,
"MUL_INT": 3
}
5 changes: 0 additions & 5 deletions examples/idct/idct.json

This file was deleted.

4 changes: 4 additions & 0 deletions examples/matrixmul2/add_int_2_mul_int3.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"ADD_INT": 2,
"MUL_INT": 3
}
4 changes: 0 additions & 4 deletions examples/matrixmul2/matrixmul2.json

This file was deleted.

File renamed without changes.
3 changes: 3 additions & 0 deletions examples/movingsum/add_int_8.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ADD_INT": 8
}
4 changes: 4 additions & 0 deletions examples/muxmul/add_int_2_mul_int3.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"ADD_INT": 2,
"MUL_INT": 3
}
4 changes: 0 additions & 4 deletions examples/muxmul/muxmul.json

This file was deleted.

4 changes: 4 additions & 0 deletions examples/polynomial2/add_int_2_mul_int3.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"ADD_INT": 2,
"MUL_INT": 3
}
4 changes: 4 additions & 0 deletions examples/polynomial2/add_int_8_mul_int15.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"ADD_INT": 8,
"MUL_INT": 15
}
4 changes: 0 additions & 4 deletions examples/polynomial2/polynomial2.json

This file was deleted.

4 changes: 4 additions & 0 deletions examples/scalar3/add_int_2_mul_int3.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"ADD_INT": 2,
"MUL_INT": 3
}
4 changes: 0 additions & 4 deletions examples/scalar3/scalar3.json

This file was deleted.

6 changes: 3 additions & 3 deletions test/model/dfcxx/idct.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ TEST(DFCxx, IdctAsap) {
IDCT kernel;
DFLatencyConfig config = {
{dfcxx::ADD_INT, 1},
{dfcxx::SUB_INT, 1},
{dfcxx::MUL_INT, 3},
{dfcxx::SUB_INT, 1}
};
EXPECT_EQ(kernel.compile(config, nullDevicePath, dfcxx::ASAP), true);
}
Expand All @@ -29,8 +29,8 @@ TEST(DFCxx, IdctAsap) {
// IDCT kernel;
// DFLatencyConfig config = {
// {dfcxx::ADD_INT, 1},
// {dfcxx::MUL_INT, 3},
// {dfcxx::SUB_INT, 1}
// {dfcxx::SUB_INT, 1},
// {dfcxx::MUL_INT, 3}
// };
// EXPECT_EQ(kernel.compile(config, nullDevicePath, dfcxx::Linear), true);
// }