Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdoc datamodel #166

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Mdoc datamodel #166

merged 6 commits into from
Nov 23, 2023

Conversation

fmarino-ipzs
Copy link
Collaborator

MDOC-CBOR Data Model

Content

This PR closes #18

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

@fmarino-ipzs fmarino-ipzs added enhancement Something improving existing features issuance labels Nov 13, 2023
@fmarino-ipzs fmarino-ipzs added this to the 0.6.0 milestone Nov 13, 2023
Copy link
Collaborator

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
Co-authored-by: Giuseppe De Marco <[email protected]>
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
docs/en/pid-eaa-data-model.rst Outdated Show resolved Hide resolved
- *tstr (text string)*. Document type returned. For example for the PID, the value MUST be ``eu.europa.ec.eudiw.pid.1.`` For an mDL, the value MUST be ``org.iso.18013-5.1.mDL``.
- [ISO 18013-5#8.3.2.1.2]
* - **issuerSigned**
- *bstr (byte string)*. Returned data elements signed by the Issuer.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppelinux , check if it sounds good to you now.

- *tstr (text string)*. Returned data elements for the namespaces. It MAY be possible to have one or more namespaces. It MAY be used for self-attested claims.
- [ISO 18013-5#8.3.2.1.2]
* - **deviceAuth**
- *bstr (byte string)*. Contains the device authentication for MDOC data authentication.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppelinux , check please

docs/en/pid-eaa-data-model.rst Show resolved Hide resolved
Co-authored-by: Giuseppe De Marco <[email protected]>

The document's data elements utilize a consistent namespace for the mandatory Mobile Driving License attributes, while the national PID attributes use the domestic namespace `eu.europa.ec.eudiw.pid.it.1`, as outlined in this implementation profile.

In compliance with ISO/IEC 18013-5, the MDOC data model in the domestic namespace `eu.europa.ec.eudiw.pid.it.1`, requires the following attributes:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppelinux, checking again the ISO it seems that a domestic namespace should be eu.europa.ec.eudiw.pid.1.IT instead of eu.europa.ec.eudiw.pid.it.1.
WDYT?

@peppelinux
Copy link
Member

@fmarino-ipzs introducing mdoc cbor has impacts on the issuance, credential_definition must use doctype instead of type or vct

* editorial: pid-eaa-data-model

some rewording and fix

* Apply suggestions from code review
@fmarino-ipzs
Copy link
Collaborator Author

@fmarino-ipzs introducing mdoc cbor has impacts on the issuance, credential_definition must use doctype instead of type or vct

I think that the Issuance protocol should be credential format agnostic. Otherwise, we have to parse the credential_definition claim according to the format one. The format should refer to the credential and not to the JSON which conveys the credential_definition claim.

@peppelinux peppelinux merged commit 48b8c21 into versione-corrente Nov 23, 2023
8 of 9 checks passed
@peppelinux
Copy link
Member

@fmarino-ipzs it's not our choice, this comes from the standards OpenID4VC and HAIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something improving existing features issuance
Projects
Development

Successfully merging this pull request may close these issues.

Pid EAA mdoc-cbor chapter
3 participants