Tier 18.3: multi-leg Fabric Lakehouse Gold variant (4-dialect parity) - #26
Merged
Merged
Conversation
Adds ddl/multileg/05_multileg_gold_fabric_lakehouse.sql - the
fourth-dialect variant of the multi-leg Gold layer. Brings
multi-leg Gold to 4-dialect parity with the option Gold layout
(Delta + Fabric Lakehouse + Fabric Warehouse + Hive).
Contains:
- gold.dim_multileg_strategy (SCD2 dimension)
- gold.fact_multileg_option_events (full post-Tier-17.5 column
set: 75 cols including all CAT IM v4.1.0r15 sec 5.2 spec
mapping columns)
- gold.fact_multileg_option_legs (per-leg detail with canonical
leg_*_indicator / leg_ratio_quantity names from Tier 17.3)
- gold.vw_multileg_option_lifecycle (consolidated lifecycle view)
- CHECK constraints on cat_event_code (25 multi-leg codes) and
leg_count >= 2
Pre-existing dialect-coverage gap closed. ddl/option/ had 4
dialects but ddl/multileg/ only had 3 - Fabric Lakehouse was
missing. The gap predated the Tier 13 audit closure work and
was flagged as followup item #3 in Tier 17.5's CHANGELOG.
Verification:
- All 8 guardrails pass.
- 10/10 regression tests pass.
- Column-name set on the 3 new tables matches the existing 3
dialects exactly - no new parity-allowlist entries required.
- DDL files in parity scope: 22 -> 23.
- Tables in 2+ dialects: 42 (unchanged - new file adds dialect
for existing tables, doesn't introduce new tables).
- New parity violations: 0.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ddl/multileg/05_multileg_gold_fabric_lakehouse.sql- the fourth-dialect variant of the multi-leg Gold layer. Brings multi-leg Gold to 4-dialect parity with the option Gold layout. Closes followup item #3 from the post-audit list.Files changed
ddl/multileg/05_multileg_gold_fabric_lakehouse.sql(NEW) - 4th-dialect mirrorCHANGELOG.md- Tier 18.3 entryWhat's in the new file
gold.dim_multileg_strategygold.fact_multileg_option_eventsgold.fact_multileg_option_legsleg_*_indicator/leg_ratio_quantitynames (Tier 17.3 renames)gold.vw_multileg_option_lifecycleCHECK constraints
fact_multileg_option_events.cat_event_code IN (25 multi-leg codes)- MLNO, MLOR, MLMR, MLCR, MLOA, MLIR, MLIM, MLIC, MLIMR, MLICR, MLCO, MLCOM, MLCOC, MLOM, MLOMR, MLOC, MLOCR, MLNQ, MLRQ, MLQS, MLQR, MLQC, MLQM, MLOS, MLOEfact_multileg_option_events.leg_count >= 2(must be multi-leg)fact_multileg_option_legs.leg_side IN ('BUY', 'SELL')Why
Pre-existing dialect-coverage gap.
ddl/option/had 4 dialects (Delta, Hive, Fabric Lakehouse, Fabric Warehouse) butddl/multileg/only had 3 - Fabric Lakehouse was missing. The gap predated the Tier 13 audit closure work and was flagged as followup item #3 in Tier 17.5's CHANGELOG.Closing this aligns the multi-leg and option Gold layouts symmetrically. A Microsoft Fabric Lakehouse deployment can now provision both option and multi-leg facts from this repo without manual translation.
Coverage
Open followups remaining
Test plan
test__ddl_parser.pyregression tests pass