chore: build check workflow fix for readstat #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shun2wang
changed the title
JorisGoosen
reviewed
Jan 22, 2025
.github/workflows/ubuntu.yml
Outdated
| @@ -61,7 +61,7 @@ jobs: | |||
| wget https://github.com/WizardMac/ReadStat/releases/download/v1.1.9/readstat-1.1.9.tar.gz | |||
| tar -xzf readstat-*.tar.gz && cd readstat-*/ | |||
| ./configure | |||
| make | |||
| make CFLAGS='-Wno-error' CXXFLAGS='-Wno-error' | |||
There was a problem hiding this comment.
Uhm, I turn this on on purpose usually?
Shouldnt we just do: -Wno-error=use-after-free instead?
There was a problem hiding this comment.
Turning it on will make the build fail, we only do this in the workflow for build test and not any local builds.
Fully fixing it would require upstream code changes (I remember you fixed this for upstream once, but not sure why it's happening again)
There was a problem hiding this comment.
Maybe some compiler got updated to be more strict or something, but this fixes it so looks good ^^
JorisGoosen
reviewed
Jan 22, 2025
Co-authored-by: Joris Goosen <[email protected]>
JorisGoosen
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JorisGoosen this could be merge to fix workflow.