Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build check workflow fix for readstat #5778

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: build check workflow fix for readstat #5778

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d54c18
chore: build check fix for readstat
shun2wang Jan 14, 2025
931cbeb
make disable werror
shun2wang Jan 14, 2025
83715de
set use-after-free
shun2wang Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
wget https://github.com/WizardMac/ReadStat/releases/download/v1.1.9/readstat-1.1.9.tar.gz
tar -xzf readstat-*.tar.gz && cd readstat-*/
./configure
make
make CFLAGS='-Wno-error' CXXFLAGS='-Wno-error'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, I turn this on on purpose usually?
Shouldnt we just do: -Wno-error=use-after-free instead?

Copy link
Contributor Author

@shun2wang shun2wang Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning it on will make the build fail, we only do this in the workflow for build test and not any local builds.
Fully fixing it would require upstream code changes (I remember you fixed this for upstream once, but not sure why it's happening again)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some compiler got updated to be more strict or something, but this fixes it so looks good ^^

shun2wang marked this conversation as resolved.
Show resolved Hide resolved
sudo make install

- name: Configure JASP desktop
Expand Down
Loading