-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "List Branches" API #1085
Conversation
@cvrebert Thanks for the pull request, let me find a reviewer.. |
@ggajos please review this one |
* @param repo Repository | ||
* @param nom Name of branch | ||
* @param sha Commit SHA hash | ||
* @checkstyle ParameterNumberCheck (6 lines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cvrebert maybe let's add PDD here to decrease number of args?
@cvrebert few comments |
@ggajos I've addressed all of your comments. |
@cvrebert build is failing now |
@ggajos Fixed. |
@cvrebert thanks |
@rultor merge |
@cvrebert looks really good |
@rultor try to merge |
@yegor256 Oops, I failed. You can see the full log here (spent 11min)
|
@yegor256 I rephrased the one |
@rultor try to merge again |
@yegor256 Oops, I failed. You can see the full log here (spent 4min)
|
@yegor256 Oops, I failed. You can see the full log here (spent 3min)
|
Sorry about that, there was a conflict with the other just-merged PR. Fixed now. @rultor merge |
@rultor merge |
@rultor try to merge again |
@yegor256 Oops, I failed. You can see the full log here (spent 8min)
|
Error is unrelated:
|
@rultor merge |
@rultor merge pls |
@rultor please deploy |
@cvrebert 2 puzzles were created here: |
Fixes #1084 by adding
Repo.branches()
, which returns aBranches
, which has aBranches.iterate()
method, which returns an iterator ofBranch
objects representing all branches in the repository using the relevant GitHub API endpoint.