-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "List Branches" API #1085
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/** | ||
* Copyright (c) 2013-2015, jcabi.com | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: 1) Redistributions of source code must retain the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer. 2) Redistributions in binary form must reproduce the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer in the documentation and/or other materials provided | ||
* with the distribution. 3) Neither the name of the jcabi.com nor | ||
* the names of its contributors may be used to endorse or promote | ||
* products derived from this software without specific prior written | ||
* permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT | ||
* NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND | ||
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL | ||
* THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, | ||
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
* OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
package com.jcabi.github; | ||
|
||
import com.jcabi.aspects.Immutable; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** | ||
* Git branch. | ||
* | ||
* @author Chris Rebert ([email protected]) | ||
* @version $Id$ | ||
* @since 0.24 | ||
* @see <a href="https://developer.github.com/v3/repos/#list-branches">List Branches API</a> | ||
*/ | ||
@Immutable | ||
public interface Branch { | ||
/** | ||
* The repo we're in. | ||
* @return Repo | ||
*/ | ||
@NotNull(message = "repo is never NULL") | ||
Repo repo(); | ||
|
||
/** | ||
* Name of the branch. | ||
* @return Branch name | ||
*/ | ||
@NotNull(message = "name is never NULL") | ||
String name(); | ||
|
||
/** | ||
* Commit that the branch currently points to. | ||
* @return Commit the branch currently points to | ||
*/ | ||
@NotNull(message = "commit is never NULL") | ||
Commit commit(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/** | ||
* Copyright (c) 2013-2015, jcabi.com | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: 1) Redistributions of source code must retain the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer. 2) Redistributions in binary form must reproduce the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer in the documentation and/or other materials provided | ||
* with the distribution. 3) Neither the name of the jcabi.com nor | ||
* the names of its contributors may be used to endorse or promote | ||
* products derived from this software without specific prior written | ||
* permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT | ||
* NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND | ||
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL | ||
* THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, | ||
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
* OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
package com.jcabi.github; | ||
|
||
import com.jcabi.aspects.Immutable; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** | ||
* Git branches. | ||
* | ||
* @author Chris Rebert ([email protected]) | ||
* @version $Id$ | ||
* @since 0.24 | ||
* @see <a href="https://developer.github.com/v3/repos/#list-branches">List Branches API</a> | ||
*/ | ||
@Immutable | ||
public interface Branches { | ||
/** | ||
* Repo which the branches are in. | ||
* @return Repo | ||
*/ | ||
@NotNull(message = "repository is never NULL") | ||
Repo repo(); | ||
|
||
/** | ||
* Iterate over all branches in the repo. | ||
* @return Iterator of branches | ||
* @see <a href="https://developer.github.com/v3/repos/#list-branches">List Branches API</a> | ||
*/ | ||
@NotNull(message = "iterable is never NULL") | ||
Iterable<Branch> iterate(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
/** | ||
* Copyright (c) 2013-2015, jcabi.com | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: 1) Redistributions of source code must retain the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer. 2) Redistributions in binary form must reproduce the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer in the documentation and/or other materials provided | ||
* with the distribution. 3) Neither the name of the jcabi.com nor | ||
* the names of its contributors may be used to endorse or promote | ||
* products derived from this software without specific prior written | ||
* permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT | ||
* NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND | ||
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL | ||
* THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, | ||
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
* OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
package com.jcabi.github; | ||
|
||
import com.jcabi.aspects.Immutable; | ||
import com.jcabi.aspects.Loggable; | ||
import com.jcabi.http.Request; | ||
import javax.validation.constraints.NotNull; | ||
import lombok.EqualsAndHashCode; | ||
|
||
/** | ||
* Git branch. | ||
* | ||
* @author Chris Rebert ([email protected]) | ||
* @version $Id$ | ||
* @since 0.24 | ||
*/ | ||
@Immutable | ||
@Loggable(Loggable.DEBUG) | ||
@EqualsAndHashCode(of = { "entry", "owner", "nam", "hash" }) | ||
public final class RtBranch implements Branch { | ||
/** | ||
* API entry point. | ||
*/ | ||
private final transient Request entry; | ||
|
||
/** | ||
* Repository we're in. | ||
*/ | ||
private final transient Repo owner; | ||
|
||
/** | ||
* Name of this branch. | ||
*/ | ||
private final transient String nam; | ||
|
||
/** | ||
* Commit SHA hash. | ||
*/ | ||
private final transient String hash; | ||
|
||
/** | ||
* Public ctor. | ||
* @param req Request | ||
* @param repo Repository | ||
* @param nom Name of branch | ||
* @param sha Commit SHA hash | ||
* @todo #1085:30m Refactor to reduce number of arguments to avoid | ||
* ParameterNumberCheck warning. | ||
* @checkstyle ParameterNumberCheck (6 lines) | ||
*/ | ||
RtBranch( | ||
final Request req, | ||
final Repo repo, | ||
final String nom, | ||
final String sha) { | ||
this.entry = req; | ||
this.owner = repo; | ||
this.nam = nom; | ||
this.hash = sha; | ||
} | ||
|
||
@Override | ||
@NotNull(message = "repo is never NULL") | ||
public Repo repo() { | ||
return this.owner; | ||
} | ||
|
||
@Override | ||
@NotNull(message = "name is never NULL") | ||
public String name() { | ||
return this.nam; | ||
} | ||
|
||
@Override | ||
@NotNull(message = "commit is never NULL") | ||
public Commit commit() { | ||
return new RtCommit(this.entry, this.owner, this.hash); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
/** | ||
* Copyright (c) 2013-2015, jcabi.com | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: 1) Redistributions of source code must retain the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer. 2) Redistributions in binary form must reproduce the above | ||
* copyright notice, this list of conditions and the following | ||
* disclaimer in the documentation and/or other materials provided | ||
* with the distribution. 3) Neither the name of the jcabi.com nor | ||
* the names of its contributors may be used to endorse or promote | ||
* products derived from this software without specific prior written | ||
* permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT | ||
* NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND | ||
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL | ||
* THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, | ||
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
* OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
package com.jcabi.github; | ||
|
||
import com.jcabi.aspects.Immutable; | ||
import com.jcabi.aspects.Loggable; | ||
import com.jcabi.http.Request; | ||
import javax.json.JsonObject; | ||
import javax.validation.constraints.NotNull; | ||
import lombok.EqualsAndHashCode; | ||
|
||
/** | ||
* Git branches. | ||
* | ||
* @author Chris Rebert ([email protected]) | ||
* @version $Id$ | ||
* @since 0.24 | ||
*/ | ||
@Immutable | ||
@Loggable(Loggable.DEBUG) | ||
@EqualsAndHashCode(of = {"entry", "request", "owner" }) | ||
final class RtBranches implements Branches { | ||
/** | ||
* RESTful API entry point. | ||
*/ | ||
private final transient Request entry; | ||
|
||
/** | ||
* RESTful request for the branches. | ||
*/ | ||
private final transient Request request; | ||
|
||
/** | ||
* Parent repository. | ||
*/ | ||
private final transient Repo owner; | ||
|
||
/** | ||
* Public ctor. | ||
* @param req Entry point of API | ||
* @param repo Repository | ||
*/ | ||
RtBranches(final Request req, final Repo repo) { | ||
this.entry = req; | ||
this.owner = repo; | ||
final Coordinates coords = repo.coordinates(); | ||
this.request = this.entry.uri() | ||
.path("/repos") | ||
.path(coords.user()) | ||
.path(coords.repo()) | ||
.path("/branches") | ||
.back(); | ||
} | ||
|
||
@Override | ||
@NotNull(message = "repository is never NULL") | ||
public Repo repo() { | ||
return this.owner; | ||
} | ||
|
||
@Override | ||
@NotNull(message = "iterable is never NULL") | ||
public Iterable<Branch> iterate() { | ||
return new RtPagination<Branch>( | ||
this.request, | ||
new RtValuePagination.Mapping<Branch, JsonObject>() { | ||
@Override | ||
public Branch map(final JsonObject object) { | ||
return new RtBranch( | ||
RtBranches.this.entry, | ||
RtBranches.this.owner, | ||
object.getString("name"), | ||
object.getJsonObject("commit").getString("sha") | ||
); | ||
} | ||
} | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cvrebert maybe let's add PDD here to decrease number of args?