feat: add AWS specific requirements

[gazal-k]

Submitter checklist

• Change is code complete and matches issue description.
• Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #6990

[jenkins-x-bot]

Hi @gazal-k. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hferentschik]

/ok-to-test

[hferentschik]

@gazal-k, thanks for the pull request. Can you provide some context what issue or usecase you are trying to solve? Maybe you could create an issue for it.

I am trying to determine what you are trying to achieve by modifying the boot requirements struct w/o any further changes to make code to make use of it.

[gazal-k]

@hferentschik I'm not entirely sure what I'm doing. I mean, I'm not sure how to fix these broken builds. What I'm trying to do essentially is, fix this issue: jenkins-x-labs/issues#17

[hferentschik]

/test all

[hferentschik]

Here is the unit test failure:

      Expected
          <string>: gcr.io/jenkinsxio-labs/**l:0.0.127
      to equal
          <string>: gcr.io/jenkinsxio/builder-maven:0.1.527
      /workspace/source/pkg/tekton/metapipeline/metapipeline_test.go:191
------------------------------
••••••
Summarizing 2 Failures:
[Fail] Meta pipeline #createMetaPipelineCRDs with extending App [It] contain three task steps 
/workspace/source/pkg/tekton/metapipeline/metapipeline_test.go:185
[Fail] Meta pipeline #createMetaPipelineCRDs with extending App [It] uses version stream for default image 
/workspace/source/pkg/tekton/metapipeline/metapipeline_test.go:191
Ran 23 of 23 Specs in 0.152 seconds
FAIL! -- 21 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestMetaPipeline (0.15s)
FAIL
FAIL	github.com/jenkins-x/**/pkg/tekton/metapipeline	7.572s
ok  	github.com/jenkins-x/**/pkg/tekton/syntax	0.597s
?   	github.com/jenkins-x/**/pkg/tekton/syntax/syntax_helpers_test	[no test files]
?   	github.com/jenkins-x/**/pkg/tekton/tekton_helpers_test	[no test files]
ok  	github.com/jenkins-x/**/pkg/terraform	0.008s
?   	github.com/jenkins-x/**/pkg/testkube	[no test files]
ok  	github.com/jenkins-x/**/pkg/tests	0.021s
ok  	github.com/jenkins-x/**/pkg/users	0.112s
ok  	github.com/jenkins-x/**/pkg/util	10.395s
ok  	github.com/jenkins-x/**/pkg/util/json	0.014s
?   	github.com/jenkins-x/**/pkg/util/mocks	[no test files]
?   	github.com/jenkins-x/**/pkg/util/secrets	[no test files]
ok  	github.com/jenkins-x/**/pkg/util/system	0.006s
?   	github.com/jenkins-x/**/pkg/util/trace	[no test files]
ok  	github.com/jenkins-x/**/pkg/vault	0.014s
?   	github.com/jenkins-x/**/pkg/vault/create	[no test files]
?   	github.com/jenkins-x/**/pkg/vault/fake	[no test files]
?   	github.com/jenkins-x/**/pkg/vault/mocks	[no test files]
?   	github.com/jenkins-x/**/pkg/vault/mocks/matchers	[no test files]
ok  	github.com/jenkins-x/**/pkg/version	0.005s
ok  	github.com/jenkins-x/**/pkg/versionstream	0.018s
?   	github.com/jenkins-x/**/pkg/versionstream/versionstreamrepo	[no test files]
?   	github.com/jenkins-x/**/pkg/virtualmachines/hyperkit	[no test files]
?   	github.com/jenkins-x/**/pkg/virtualmachines/kvm	[no test files]
?   	github.com/jenkins-x/**/pkg/virtualmachines/kvm2	[no test files]
?   	github.com/jenkins-x/**/pkg/virtualmachines/virtualbox	[no test files]
?   	github.com/jenkins-x/**/pkg/workflow	[no test files]
make: *** [Makefile:105: test] Error 1

[gazal-k]

/test all

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rajdavies

If they are not already assigned, you can assign the PR to them by writing /assign @rajdavies in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gazal-k]

I got the same error running make lint on master as on my feature branch:

FAILED make verify-generation-complete
RUN make generate-docs
make[1]: Entering directory '/home/mgazal/go/src/github.com/jenkins-x/jx'
Generating HTML docs for Kubernetes Clients
./build/codegen --generator-version 9642bd3f4de5 docs
INFO[0000] generating docs to /home/mgazal/go/src/github.com/jenkins-x/jx/docs/apidocs  app=codegen
INFO[0000] installing github.com/kubernetes-incubator/reference-docs/gen-apidocs in version 9642bd3f4de5 via 'go get'  app=codegen
INFO[0002] copying static files from /home/mgazal/.jx/codegen/go/pkg/mod/github.com/kubernetes-incubator/[email protected]/gen-apidocs/generators/static to /home/mgazal/go/src/github.com/jenkins-x/jx/docs/apidocs/static  app=codegen
make[1]: Leaving directory '/home/mgazal/go/src/github.com/jenkins-x/jx'
PASSED make generate-docs
make: *** [Makefile:216: lint] Error 1

I suppose lint is just broken and not as a result of this change

[gazal-k]

I got the same error running make lint on master as on my feature branch:

FAILED make verify-generation-complete
RUN make generate-docs
make[1]: Entering directory '/home/mgazal/go/src/github.com/jenkins-x/jx'
Generating HTML docs for Kubernetes Clients
./build/codegen --generator-version 9642bd3f4de5 docs
INFO[0000] generating docs to /home/mgazal/go/src/github.com/jenkins-x/jx/docs/apidocs  app=codegen
INFO[0000] installing github.com/kubernetes-incubator/reference-docs/gen-apidocs in version 9642bd3f4de5 via 'go get'  app=codegen
INFO[0002] copying static files from /home/mgazal/.jx/codegen/go/pkg/mod/github.com/kubernetes-incubator/[email protected]/gen-apidocs/generators/static to /home/mgazal/go/src/github.com/jenkins-x/jx/docs/apidocs/static  app=codegen
make[1]: Leaving directory '/home/mgazal/go/src/github.com/jenkins-x/jx'
PASSED make generate-docs
make: *** [Makefile:216: lint] Error 1

I suppose lint is just broken and not as a result of this change

that was just some GOPATH issues. Figured out why lint was broken

[hferentschik]

@gazal-k, I am going to close this pull request. This change is really targeting jxl and the multicluster branch. These were really experiments. There is ongoing work for implementing multicluster right now and for other parts of the experiment we need to see how we move forward. IMO it would feel premature to merge this atm.

[gazal-k]

no worries @hferentschik . I created another issue: jenkins-x/terraform-aws-eks-jx#31 so we can continue the discussion and perhaps come up with a better solution