[JENKINS-75409] SSLContext typo fix and consider it in pingSuccessful method #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbhat618
commented
Mar 11, 2025
gbhat618
commented
Mar 11, 2025
Contributor
Author
|
logged in here |
gbhat618
changed the title
14 tasks
gbhat618
changed the title
Member
Does it not accept |
jglick
reviewed
Mar 13, 2025
Contributor
Author
it is logged in here https://issues.jenkins.io/browse/JENKINS-75005 Also reproducing in test after IAR introduces reproduce diffdiff --git a/src/test/java/org/jvnet/hudson/test/RealJenkinsRuleHttpsTest.java b/src/test/java/org/jvnet/hudson/test/RealJenkinsRuleHttpsTest.java
index 1fe49593..967167e0 100644
--- a/src/test/java/org/jvnet/hudson/test/RealJenkinsRuleHttpsTest.java
+++ b/src/test/java/org/jvnet/hudson/test/RealJenkinsRuleHttpsTest.java
@@ -64,6 +64,17 @@ public class RealJenkinsRuleHttpsTest {
iar.createAgent(rr, options.build());
}
+ @Test
+ public void inboundAgentWithCertByPath() throws Throwable {
+ var pathValue = "@" + getClass().getResource("/https/test-cert.pem").getPath();
+ var options = InboundAgentRule.Options
+ .newBuilder()
+ .name("remote")
+ .webSocket()
+ .cert(pathValue);
+ iar.createAgent(rr, options.build());
+ }
+
private static void log(JenkinsRule r) throws IOException {
LOGGER.info("Running on " + r.getURL().toExternalForm());
}
(END)failure logI will check on that after the IAR PR above is merged. |
Contributor
Author
|
core IT is passing (link to build) |
Contributor
Author
|
(CI has failed in git checkout |
Contributor
Author
|
(ig, I will just do |
Contributor
Author
|
(The same issue happened again, probably something to do with the network config of the windows controller) - I will re-trigger CI tomorrow. |
Member
FTR no, the Windows agents need to git config --add --global http.sslBackend openssl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-75409
Self signed TLS certificate passing was not working with WebSocket agents.
-cert(also affected TCP agent)passing the
-certis actually a bit tricky need to pass as,-noCertificateCheck(this worked in TCP agent)Only passing the trustStore with the locally created CA was working
-Djavax.net.ssl.trustStore=mytruststore.jks.Testing done
Automated testing in jenkinsci/jenkins#10396
Failure simulated for these tests
tcpWithCertByValue: fails due to sslContext typo
log snippet
webSocketNoCertificateCheck: fails due to pingSuccessful method falling to default java ssl, not the sslContext with certificate check disabled.
log snippet
webSocketWithCertByValue: fails due to sslContext typo and pingSuccessful method not using the sslContext object.
log snippet
core IT is passing after this incremental remoting version is used in there. (link to build test report)
Submitter checklist