[JENKINS-75409] Write a core it test for -noCertificateCheck and -cert for inbound agents

[gbhat618]

See JENKINS-75409

---

This PR adds an integration test for remoting -noCertificateCheck and -cert.
It is being added in the context of fixing - upstream remoting issue jenkinsci/remoting#786

Testing done

3 Tests (webSocketNoCertificateCheck, webSocketWithCertByValue, tcpWithCertByValue) are is expected to fail until the upstream remoting incremental build referred. Then tests are expected to succeed.

• failure is correctly simulated for now ✅ (build 6)
• tests are passing after using remoting incremental version (build 8) ✅
• EDIT: The upstream remoting change has been merged, and the new release is now reflected in Jenkins' pom.xml.

Proposed changelog entries

• Adding an integration test for inbound agent when Jenkins running with https.

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jglick , @Vlatombe

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[gbhat618]

not sure if DisconnectNodeCommandTest#disconnectNodeShouldSucceedWithCause is a flake, it failed on linux-java17 (but passed in java21). In my local works for both java 17 and java 21.

Retriggered the CI by sending empty commit.

[gbhat618]

failed again on JDK17 (passes on JDK21); checking 👀
DisconnectNodeCommandTest#disconnectNodeManyShouldSucceed

Previously failed was,
DisconnectNodeCommandTest#disconnectNodeShouldSucceedWithCause

[gbhat618]

both case assertions are same, seems like flake tests - as each of these succeeded once and failed again.

java.lang.AssertionError: 

Expected: an instance of hudson.slaves.OfflineCause$ByCLI
     but: <Connection was broken> is a hudson.slaves.OfflineCause$ChannelTermination

It seems like the CLI's disconnect command terminating agent - may not always gracefully terminate the agent (?) and Connection was broken gets recorded as the disconnect cause 🤔

[gbhat618]

for the flake fix, there was a PR merged #10307

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[gbhat618]

Noted about the flakey tests in https://issues.jenkins.io/browse/JENKINS-75456 will work on that first, and then come back to this task.

[gbhat618]

Deflaking tests PR: #10425

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[gbhat618]

Please take a moment and address the merge conflicts of your pull request. Thanks!

will wait #10455 to merge as that contains the upstream changes required

[gbhat618]

This PR is ready

[timja]

LGTM

[krisstern]

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

[A1exKH]

LGTM.