fixes run's single method #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 70.41% 72.30% +1.89%
==========================================
Files 25 25
Lines 4140 4127 -13
==========================================
+ Hits 2915 2984 +69
+ Misses 1225 1143 -82
Continue to review full report at Codecov.
|
IAlibay
commented
Jul 16, 2020
speleo3
reviewed
Jul 16, 2020
speleo3
reviewed
Jul 16, 2020
|
Also, awesome test coverage... isn't it nice when one commit increases overall coverage by 2%! |
Co-authored-by: Oliver Beckstein <[email protected]>
speleo3
approved these changes
Jul 17, 2020
orbeckst
approved these changes
Jul 17, 2020
orbeckst
added a commit
to Becksteinlab/propka
that referenced
this pull request
Jul 18, 2020
- docs use versioneer-based propka.__version__ - also added @IAlibay to authors (forgotten in previous PRs jensengroup#84 and jensengroup#85) - generate a sitemap (add sphinx_sitemap to requirements.txt)
orbeckst
added a commit
that referenced
this pull request
Jul 18, 2020
- fix #87 - user versioneer for version management - use tag "vMAJOR.MINOR.PATCH" to indicate release number - exclude generated files from coverage; also exclude tests from coverage reporting; allow use of "# pragma: no cover" to exclude lines of code from coverage - configure coverage with entries in setup.cfg (removed commandline config from workflows/python-package.yml) - related doc updates - make docs automatically use current version (docs use versioneer-based propka.__version__) - also added @IAlibay to authors (forgotten in previous PRs #84 and #85) - generate a sitemap (add sphinx_sitemap to requirements.txt) - add test_version Note: Versioneer-generated version is “0-untagged” on the branch where it is tested so need to add it to a valid result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Changes:
read_molecule_filein Allows for file-like objects to be passed to read_molecule_file #84test_runfile specific for testingrun.Notes:
test_runoverlap a lot withtest_streamio, strictly speaking I could probably ditch part oftest_streamioas it's implicitly tested. However in some ways it might be good to have the two run in parallel to make sure that some change in run.single isn't introducing new behaviour. Either way would work, but it might not be that big a deal with the tests running as fast as they currently do?To do:Add in a test for the logger warning.