Fix cellpycore 0.2.2 sync fallout: merger summary test_id + stale tests#524
Merged
Conversation
Core #136 bridges test_id through the legacy steps/summary output, which left four non-essential tests failing on master and exposed a merger bug: campaign_fold concatenated the right-hand summary without remapping its test_id, so a merged (pre-recompute) summary carried test_id=0 on every row and would round-trip wrongly through v9. - merger: remap the right summary's test_id via the merge id-map (mirrors the raw handling) - cellreader: drop the #507 re-stamp workaround in make_step_table (core 0.2.2 delivers test_id directly) - tests: update the .h5 -> .cellpy default-extension expectations and the single-test no-test_id assertion; add a regression test for the merger remap Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 17, 2026
jepegit
added a commit
that referenced
this pull request
Jul 17, 2026
…) (#532) The essential-only gate let four non-essential test failures land on master (fixed in #524). The full linux suite runs in ~3 min, so the marker split no longer buys much on linux: add a full-suite job to the tier-1 workflow, mirroring the essential job's setup and the tier-3 linux ignore (plotutils summary plot needs a display). Making it required is a branch-protection (admin) flip once this lands. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 17, 2026
jepegit
added a commit
that referenced
this pull request
Jul 18, 2026
On a native cell, merge()/campaign_fold now works: translate self.data and copies of the participants to legacy names (keeping test_id on every frame so the merge's per-source id assignments survive), run the existing legacy merge machinery (_append / campaign_fold, incl. the #524 test_id remap + renumber_cycles), then translate the result back to native. Copies keep the source cells' native frames intact. Drops the NotImplementedError; replaces test_native_merge_raises with native campaign + continuation merge round-trip tests. The legacy test_merge_campaign suite stays pinned to native_schema=False as it validates the core machinery the native path round-trips through. Full suite: 677 passed. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cellpycore 0.2.2 (core #136) bridges
test_idthrough the legacy steps/summary output. The Milestone C sync (#523) regenerated goldens but left four non-essential tests failing on master and exposed a real merger bug.campaign_foldconcatenated the right-hand summary without remapping itstest_id, so a merged (pre-recompute) campaign summary carriedtest_id=0on every row — and would round-trip wrongly through v9. The right summary is now remapped via the merge id-map, mirroring the raw-frame handling.make_step_table— core 0.2.2 deliverstest_idon the bridge output directly, which was the point of core Make the C-rate available in the summary file #136.test_save_cellpyfile_auto_extension*tests now expect the v9.cellpydefault (v9 cellpy-file format (zip-of-parquet) — #510 Milestone A #521);test_single_test_steps_have_no_test_id_columnflipped to assert the bridgedtest_id=0.test_campaign_merge_remaps_summary_test_id.Test plan
🤖 Generated with Claude Code