deps: bump github.com/hashicorp/hcl/v2 from 2.20.1 to 2.24.0 - #10
Closed
dependabot[bot] wants to merge 1 commit into
Closed
deps: bump github.com/hashicorp/hcl/v2 from 2.20.1 to 2.24.0#10dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.20.1 to 2.24.0. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md) - [Commits](hashicorp/hcl@v2.20.1...v2.24.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcl/v2 dependency-version: 2.24.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/hashicorp/hcl/v2-2.24.0
branch
from
August 1, 2025 05:48
6ec0249 to
b4e26bd
Compare
jingle2008
added a commit
that referenced
this pull request
Mar 29, 2026
Owner
|
Superseded by #17 which updates all dependencies at once. |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/go_modules/github.com/hashicorp/hcl/v2-2.24.0
branch
March 29, 2026 19:52
jingle2008
added a commit
that referenced
this pull request
May 17, 2026
#6 (pkg/models/base_model): document that GetDefaultDacShape returns a pointer aliasing an element of the underlying CompatibleDACShapes slice. Mutating it is visible to every BaseModel that shares the same *DacShapeConfigs. Treat as read-only. #7 (internal/ui/tui/reducer_actions): rename local `key` variables to `itemKey` in scaleUpGpuPool / cordonNode / drainNode / getSelectedItem. The locals were shadowing the bubbles/key package import (no bug — Go scopes correctly — but the rest of the file uses `itemKey` and the parity is worth having). #10 (internal/cli/output/WriteJSONL): document that "_group" is a reserved field name used to carry the originating map key when flattening keyed inputs; callers must not name a JSON field "_group" or it will be silently overwritten. #5 (internal/cli/output/WriteJSONL): add a TODO(perf) note about the marshal→unmarshal→remarshal roundtrip in the map path. ~3× steady-state memory of a streaming writer; acceptable for current dataset sizes, revisit with reflect-based streaming if profiles show it as a hotspot. Minor #8 (//nolint:cyclop on emitCategory) and Minor #9 (Categories global unused outside tests) deliberately not addressed per the reviewer's own guidance — both were explicitly out of scope. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jingle2008
added a commit
that referenced
this pull request
May 18, 2026
Sweeps the remaining review items #6, #7, and the relevant Minors: - #6 + Minor #9: merge validateMutationConfig and validateScaleConfig into a single function with (needsKube, needsRepo) booleans. Drop the unreachable "missing --kubeconfig" branch — the persistent flag always supplies ~/.kube/config so the os.Stat guard is the real check. - #7: each mutation tool description now spells out that mutations target the server's startup env only; env_* fields in the arguments are silently ignored by the JSON unmarshaler. Header comment in registerMutationTools explains the reasoning. - Minor #8: fold requireConfirm into runMutationTool. Each handler now makes a single call with `in.Confirm` and a perform closure instead of the previous two-step gate + execute. The 4-value return is gone; refusal becomes the same shape as failure. - Minor #12: fix doc-level wording — delete.Short adds "the", scale.Short drops the misleading plural, reboot.Long rewords "fire-and-forget" so it doesn't read as "OCI finished". Minor #10 was based on misreading the perform-vs-runMutation ordering; the "no change" note already prints before "OK". No change needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jingle2008
added a commit
that referenced
this pull request
May 24, 2026
Code-review follow-up to the four-commit ImportedModel feature (02fdba7 .. 2c1090e). All review feedback addressed: Important #1 — MCP description claimed a `source` field that was dropped in 0d194ae. Replaced with the orthogonality guidance the Go doc and CHANGELOG now use. Agents planning JSON paths against the tool description will no longer be misled. Important #2 — CHANGELOG was missing the silent BaseModel filter change (02fdba7). Added a `### Changed` entry explicit about the count delta — `toolkit get basemodel -o json | jq length` returns fewer items on clusters with tenant-scoped CBMs. Points readers at the new `importedmodel` category to recover the full set. Important #3 — Confirmed via inventory of pkg/models that ImportedModel is the only category with both Namespace and TenantID (DAC, LimitTenancyOverride, ConsolePropertyTenancyOverride each have TenantID alone). Adopting the DAC pattern: TenantID is the OCI tenant identifier (from `tenancy-id` label, populated on any source that carries the label); Namespace is the K8s scope (the authoritative source-kind indicator). They're orthogonal facets, not synonyms. Loader behavior unchanged — only documentation flips, in three places: - pkg/models/imported_model.go: expanded doc-comment with the "orthogonal facets" framing and explicit consumer guidance ("which K8s scope" vs "which OCI tenant"). - internal/mcp/tools.go (list_imported_models description): same clarification, replacing the stale `source` mention. - CHANGELOG: same framing, with the DAC-pattern reference. Important #4 — Added a deliberate comment in LoadImportedModels explaining the all-or-nothing semantics vs. the LoadGpuPools partial-error idiom. The two sources here are conceptually one catalog; a half-loaded result is more confusing than an explicit error, and the cross-GVR RBAC asymmetry (namespaced `basemodels` vs cluster-scoped `clusterbasemodels`) is the realistic failure mode the comment calls out. Minor #5 — TestList_ImportedModels_FlatShape doc-comment said the test asserts `source` is present; corrected to reflect that the test now asserts `source` is absent (the post-0d194ae contract). Skipped from the review's Minor list: - #6 (lint suppression placement) — pre-existing, no change. - #7 (split routeLoadingDataMsg following the routeList* pattern) — could land in a follow-up if the next addition pushes the message count above the cyclop ceiling again; not urgent at 10. - #8 (ResetScopedData consistency) — already correct. - #9 (StorageURI placement on BaseModel vs ImportedModel) — already the right call, no change. - #10 (CLI table readability) — passed review. Verified: go test ./..., make fmt-check, make goimports-check, golangci-lint run ./... all green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/hashicorp/hcl/v2 from 2.20.1 to 2.24.0.
Release notes
Sourced from github.com/hashicorp/hcl/v2's releases.
Changelog
Sourced from github.com/hashicorp/hcl/v2's changelog.
Commits
6b50680Update CHANGELOG.md (#764)77ef278ops: handle unknown objects correctly when looking up by index (#763)dfa124f[Compliance] - PR Template Changes Required (#761)6b5c4c2fix errors thrown by errcheck linter (#755)61bd79dsuppress and fix lint errors by unused (#754)8b8cb9cbuild(deps): bump golangci/golangci-lint-actionaa4e447build(deps): bump actions/setup-go7244363Update go-cty to latest (#749)b4e27aetest_suite: refactor schema validation of diagnostic file range, pos (#750)314d236fix staticcheck lint errorsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)