Skip to content

Merge pull request #414 from jstourac/renamegha #169

Merge pull request #414 from jstourac/renamegha

Merge pull request #414 from jstourac/renamegha #169

Triggered via push October 7, 2024 08:57
Status Failure
Total duration 40s
Artifacts
Matrix: golangci-lint
Matrix: govulncheck
Fit to window
Zoom out
Zoom in

Annotations

20 errors
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L395
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/notebook_controller_bdd_test.go#L65
S1008: should use 'return err == nil' instead of 'if err != nil { return false }; return true' (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/notebook_controller.go#L96
S1021: should merge variable declaration with assignment on next line (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_route.go#L47
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L187
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L210
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L144
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L145
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)