Merge pull request #414 from jstourac/renamegha #169
Annotations
10 errors
|
golangci-lint:
components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
|
|
golangci-lint:
components/notebook-controller/controllers/suite_test.go#L43
var `cfg` is unused (unused)
|
|
golangci-lint:
components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)
|
|
golangci-lint:
components/notebook-controller/controllers/culling_controller.go#L395
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)
|
|
golangci-lint:
components/notebook-controller/controllers/culling_controller.go#L380
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
|
golangci-lint:
components/notebook-controller/controllers/culling_controller.go#L406
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
|
golangci-lint:
components/notebook-controller/controllers/notebook_controller_bdd_test.go#L65
S1008: should use 'return err == nil' instead of 'if err != nil { return false }; return true' (gosimple)
|
|
golangci-lint:
components/notebook-controller/controllers/notebook_controller.go#L96
S1021: should merge variable declaration with assignment on next line (gosimple)
|
|
golangci-lint:
components/notebook-controller/api/v1beta1/notebook_webhook.go#L24
var `notebooklog` is unused (unused)
|
|
golangci-lint:
components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
|
Loading